Binaryify / OneDark-Pro

Atom's iconic One Dark theme for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=zhuangtongfa.Material-theme
MIT License
1.52k stars 289 forks source link

The color scheme looks a lot of red #553

Open fuyunliu opened 3 years ago

fuyunliu commented 3 years ago

Describe the bug A clear and concise description of what the bug is.

Screenshots & Example Code

image

Desktop (please complete the following information):

jk123vip commented 3 years ago

same issue

lromanov commented 3 years ago

@fuyunliu Is seems you use Pylance plugin. If you disable it the redness would decrease. Nevertheless this behaviour is quite strange indeed.

Binaryify commented 3 years ago

@fuyunliu @jk123vip @lromanov you could add this in your settings.json

"editor.semanticTokenColorCustomizations": {
    "rules": {
      "parameter:python": "#aaaaaa"
    }
  },
Binaryify commented 3 years ago

@marcpinet install Pylance plugins

marcpinet commented 3 years ago

@marcpinet install Pylance plugins

I installed Pylance plugins, now I have the same issue above (almost everything is red) I also tried to copy/paste what you asked them to add in our settings.json but still doesn't work.

In my settings.json, when I put "python.languageServer": "None",

where None replaces Pylance, it fixes the issue

Binaryify commented 3 years ago

@marcpinet read this https://github.com/Binaryify/OneDark-Pro#python--pylance-users

marcpinet commented 3 years ago
      "editor.tokenColorCustomizations": {
        "textMateRules": [
          {
            "scope": "support.type.exception.python",
            "settings": {
            "foreground": "#ffbe32"
            }
          },
          {
            "scope": "meta.fstring.python",
            "settings": {
              "foreground": "#D19A66"
            }
          },
          {
            "scope": "meta.item-access.python",
            "settings": {
              "foreground": "#E06C75"
            }
          },
          {
            "scope": "meta.function-call.arguments.python",
            "settings": {
              "foreground": "#D19A66"
            }
          }
        ]
      },

This fixed my issue partially

victororlyk commented 1 week ago

it would be cool to have an option with some other then read color as main