Theme Options

[whippingdot]

I want to have different versions of this theme, like a WAY darker dark, and maybe an 'Ocean' style

Long Intro

I always come back to this theme because it has no white like almost anywhere in the code files. The variables are colorized, which almost no other theme has. But, I want more. A new theme called Starfall was released (check it out), which looks amazing, the color scheme and everything are mind-blowing 🤯 ! In Starfall, the reason I like it is that in Starfall Ocean it uses a very dark blue as the background color which makes the editor look super nice! I personally think dark blues look better than grey, so...

Coming to the point

My hope is that you can add more options to the theme styles. Right now you have One Dark Pro (the default), flat (which I don't like), and dark (which is darker, but still a very light grey so if you could make it more darker that would be nice). Maybe you could make the dark darker, or add a darker dark style...or the one I really want is an Ocean variant, which uses a lot of blue. If you could implement one of these it would be nice...thanks!

Screenshot of Starfall Ocean

Screenshot of One Dark Pro Dark

Oh BTW another request - maybe add an option in your theme to allow users to choose the color of the variables and also remove the option to use nord themes or whatever in settings to slow down the startup time?

[Binaryify]

v3.12.0 support Ocean theme and dynamically loading themes files, also I add variables colors settings could you try https://github.com/Binaryify/OneDark-Pro/blob/feedback/onedarkpro-3.12.0.vsix before I publish it to the vscode's marketplace? I need some feedback

[Binaryify]

you can use this to install the vsix

[whippingdot]

@Binaryify hey, I downloaded it and added it. Where can I try the ocean theme? Also did you use the color scheme of that (like create your own custom version of it) or did you just use the same CSS as theirs?

[Binaryify]

check this

[Binaryify]

also you need to apply the default theme

[whippingdot]

No yea I manually reloaded the vs code and I see the ocean theme option

I clicked on the option yet it still isn't changing the color scheme

[whippingdot]

Oh wait @Binaryify I just saw the comment saying you have to change the default theme to one dark pro too - it is working now

Thanks!

BTW could you call this 'One Dark Pro Ocean' and add it as one of the default options too? That might attract more people to that specific option and they could stick with the theme

[whippingdot]

Also this would make it so the default theme wont have to be one dark pro and you won't have to go deep in to the settings to make ocean work. Just add it in the 'Preferences: Color Themes' list of themes in vs code

[Binaryify]

maybe I should also move other built in themes to the vscode theme list, what do you think

[whippingdot]

yeah...but something I mentioned in the first comment of this issue thread was that I think the other built in themes should be removed - don't they take up unnecessary space?

[Binaryify]

yes, that need take up unnecessary space, so I add dynamic loading themes file feature in this version, actually some people like use other editor theme but like OneDark's code highlight, I don't know should I remove that built-in themes and tell theme how to combine other editor theme they like in the vscode's settings.json ? or keep them and add Ocean theme and more

[whippingdot]

Ok, so first yes I admit I like OneDark's syntax highlighting more than other themes. If dynamic loading theme files saves space on the PC, then leave the built-in themes otherwise remove them. If it does save space, then also try thinking of creative names for each theme, like 'One Dark Pro Ocean' instead of 'One Dark Pro Starfall Ocean'.

BTW if you do remove the other built-in themes and add the tutorial on how to combine themes, try to keep it upfront or open a file that tells them how to when installing the theme, so people are aware that that is an option.

P.S. An unnecessary question but are you British or American - do you know English well?

[whippingdot]

Oh BTW I found a glitch with the Ocean theme, there are no hover effects. I think in starfall ocean there are no hover effects too but it would be better if you edited the theme to have hover effects when you hover over things like these

[Binaryify]

i'm a chinese, so my english is just so so actually I don't suggest make many other editor themes in this theme, it look like I stole other author's theme and also I don't have time to maintain those theme this it why I didn't let those themes show in theme list

vscode also can easy to custom theme first switch the theme what you like then press "ctrl+shift+p", input theme and choose "generate color theme from current setting" option then copy the colors code snippet then open the settions.json add or edit the workbench.colorCustomizations", put the colors code snippet to it press ctrl + s then switch the One Dark Pro theme and you will find your editor theme already become the theme what you just copy and it keep the One Dark Pro's code highlight

[Binaryify]

Ok, so first yes I admit I like OneDark's syntax highlighting more than other themes. If dynamic loading theme files saves space on the PC, then leave the built-in themes otherwise remove them. If it does save space, then also try thinking of creative names for each theme, like 'One Dark Pro Ocean' instead of 'One Dark Pro Starfall Ocean'.

BTW if you do remove the other built-in themes and add the tutorial on how to combine themes, try to keep it upfront or open a file that tells them how to when installing the theme, so people are aware that that is an option.

P.S. An unnecessary question but are you British or American - do you know English well?

I suggest you create a issue in Starfall Ocean GitHub repo, this helps maintain the theme, when they fix that, you can let me know and I will update this theme

[opqpop]

Hi, I just upgraded and my One Dark Pro looks completely different from before, what settings can I pick to get it back to how it looked the previous version? This is making me want to use a different color theme unless I can get back to the way it used to look.

Or another question, is there a way I can downgrade back to the old version?

My previous version had a much darker background than the previous version

Was it "VS Code" editor theme? This one seems to match the previous one closest but it still doesn't feel right. Just Dark is too dark so that wasn't what I was using originally

Also, the current default editor theme "One Dark Pro" is completely different, it has a lighter background which I don't want.

[Binaryify]

@opqpop you can click this to install old version, and could you provide the screenshots what you think is different

[opqpop]

Ah thank you, after looking at it more in detail, it seems VSCode theme was indeed the one I was using, so no need to downgrade anymore. Sorry for the thrash.

[Binaryify]

@opqpop ah, it's fine, thanks for your support~