search

Binaryify / OneDark-Pro

Atom's iconic One Dark theme for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=zhuangtongfa.Material-theme
MIT License
1.52k stars 289 forks source link

Bold & Italics not working #606

Closed whippingdot closed 3 years ago

whippingdot commented 3 years ago

Describe the bug I think I remember when I first used the theme there used to be bold highlighting for function names and italics for comments or something like that right? For the last few months I haven't seen any bold or italic highlighting in my C++ code, or Python code I think, and I was wondering if you could see if it was an error in the theme or if something was wrong on my end and you knew how to fix it. Thanks for the help BTW!

To Reproduce Steps to reproduce the behavior:

  1. Enable Bold on some Scopes
  2. Enable Italic on some Scopes
  3. Watch and see that there is no bold or italic anywhere (I don't even know what vivid colors does but that also might not be working)

Expected behavior I expect to see bold colors in function names and in other places, and italic code in some places like comments or something else too (whatever is supposed to happen normally)

Screenshots & Example Code image image

Desktop (please complete the following information):

Binaryify commented 3 years ago

One Dark Pro Flat/One Dark Pro Darker didn't support set bold& italics before v3.12.0 support that could you try https://github.com/Binaryify/OneDark-Pro/blob/feedback/onedarkpro-3.12.0.vsix before I publish it to the vscode's marketplace? I need some feedback

Binaryify commented 3 years ago

image image

you can use this to install the vsix

whippingdot commented 3 years ago

installed it, reloaded editor multiple times, yet I don't seem to have bold or anything still.

whippingdot commented 3 years ago

No wait it works now, the bold is very hard to see so I didn't notice. NOICE!

BTW it is hard to see for me cause i have a small font size lol.

Binaryify commented 3 years ago

@whippingdot this extension had a data reference problem, it make setting change sometime don't work, it should be normal after v3.13.0

whippingdot commented 3 years ago

Kk

Sent from my iPad

On Sep 30, 2021, at 7:44 AM, binaryify @.***> wrote:



@whippingdothttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fwhippingdot&data=04%7C01%7C%7C702f83b78b8a46a91d2108d983b817ed%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637685648960983726%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=XWZ7%2F8ZPy1Amvrj5woLijy%2FimjPsH6iT%2BqsB%2FQpvpVA%3D&reserved=0 this extension had a data reference problem, it make setting change sometime don't work, it should be normal after v3.13.0

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FBinaryify%2FOneDark-Pro%2Fissues%2F606%23issuecomment-930693462&data=04%7C01%7C%7C702f83b78b8a46a91d2108d983b817ed%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637685648960993720%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=vfwRgBc6CJDYqozG%2BoVmm%2FvmrP%2F2aWN%2FF0esq85n1kg%3D&reserved=0, or unsubscribehttps://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAPK7RQZBYOVJ2C7UZYOVBHDUEPBZ3ANCNFSM5DYRQSDA&data=04%7C01%7C%7C702f83b78b8a46a91d2108d983b817ed%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C637685648960993720%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=b9%2FTG%2BaSHrqRyQ0qr%2FgbEusHFH8rPIczCIWFb8g0C2Q%3D&reserved=0.