Binaryify / OneDark-Pro

Atom's iconic One Dark theme for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=zhuangtongfa.Material-theme
MIT License
1.52k stars 289 forks source link

Javascript red coloring everywhere #61

Closed rafamel closed 7 years ago

rafamel commented 7 years ago

The current styling on Javascript is too overwhelming as compared to the original Atom One Dark syntax. The red takes over everything pretty easily.

This is OneDark Pro: OneDark Pro

This is Atom's original One Dark: Atom's original One Dark

Is this an issue or is it by design?

Binaryify commented 7 years ago

By design, the original one is too pale

offirgolan commented 7 years ago

I have to agree with @rafamel. Literally everything is red.

screen shot 2017-05-12 at 5 28 35 pm

I absolutely love this theme but find the JS syntax to be unreadable.

Binaryify commented 7 years ago

@rafamel @offirgolan Everyone's aesthetic is different, so I provide this DOCS to help everyone to DIY https://binaryify.github.io/OneDark-Pro

will-stone commented 7 years ago

@binaryify the whole point of this theme is to mimic One Dark. Surely we can try to change this?

Binaryify commented 7 years ago

@will-stone Of course you can, you just need know the code scope and change it's color

will-stone commented 7 years ago

After fixing all the workbench theme, providing a new logo, and correcting all the documentation, I kinda feel like I'm taking over. I've also checked out the JS theme vs Atom's and it is quite drastically different to yours. I've decided to create and maintain my own. Thanks for helping me get into the world of theming.

offirgolan commented 7 years ago

@will-stone please link to it when you get a chance 😄

will-stone commented 7 years ago

@offirgolan I decided that this theme should really be the home of the One Dark clone and don't want to step on Binaryify's efforts. Therefore, please make any requests for changes to this theme here. I chose a simpler, darker look, which I prefer. I am also experimenting with deprioritising punctuation (you'll have to install to see what I mean there). Anyway, you can find the theme here: http://wstone.io/plastic/

offirgolan commented 7 years ago

@will-stone I think that is fair. Thank you for the update and I'll give plastic a shot!