Binaryify / OneDark-Pro

Atom's iconic One Dark theme for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=zhuangtongfa.Material-theme
MIT License
1.52k stars 289 forks source link

the stripe is too bright #670

Closed kidsamort closed 2 years ago

kidsamort commented 2 years ago

I use the one dark pro flat theme precisely because it has minimal borders, but since the recent update, the terminal window has changed and I've been waiting for half a year, it constantly distracts me, could you tell me how to make the bright stripe I marked less noticeable and disturbing like the others image

Binaryify commented 2 years ago

you can add this in your setting.json before I release next version

"workbench.colorCustomizations": {
    "terminal.border": "#21252b"
  },

and it will look like this image

Binaryify commented 2 years ago

you can check v3.13.9 now~

kidsamort commented 2 years ago

вы можете проверить v3.13.9 сейчас ~

thanks for such a quick revision, happy new year))

njbbaer commented 2 years ago

@Binaryify I'd like you to reconsider the new color you chose for this. I'm a user of OneDark Pro Darker and it's almost impossible for me to see where one terminal begins and another ends when stacked vertically. For now I've overridden it in my own settings.

I agree the old border stood out too much, but the new one shouldn't be quite so dark. I suggest it matches panel.border which I think is #3e4452

Binaryify commented 2 years ago

@njbbaer you mean set terminal.border to #3e4452 or panel.border to #3e4452 or both I think both is fine and it look like this image what do you think @kidsamort

kidsamort commented 2 years ago

"workbench.colorCustomizations": { "terminal.border": "#21252b" }, I'll probably stay with these settings because I don't need light border , I already know ui ide so i use "one dark pro flat" the only thing I need (border) them for is to change sizes @Binaryify

kidsamort commented 2 years ago

image maybe I'm used to it, but for me it's intuitively clear where it ends

Binaryify commented 2 years ago

maybe should let user custom it, it's hard to have consensus @njbbaer @kidsamort

kidsamort commented 2 years ago

maybe should let user custom it, it's hard to have consensus @njbbaer @kidsamort

do what that guy wants I think it will be better for everyone and I will stay with the settings

njbbaer commented 2 years ago

@kidsamort The terminals are easier to distinguish when placed horizontally like that, but hard to see when stacked vertically.

Screenshot from 2022-01-04 17-50-13

@Binaryify This is what I have in my settings. I set terminal.border to match panel.border which is much clearer to my eyes.

"workbench.colorCustomizations": {
    "terminal.border": "#3e4452"
},

Obviously if you don't decide to change it I'll just keep these custom settings. But I assume anyone who stacks their terminals vertically like I do would want the border to stand out, at least a little bit.

Screenshot from 2022-01-04 17-52-54

Binaryify commented 2 years ago

consider set terminal.border and panel.border to "#3e4452" what do you think @kidsamort @njbbaer

njbbaer commented 2 years ago

Looks great, thank you! ⭐