Binaryify / OneDark-Pro

Atom's iconic One Dark theme for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=zhuangtongfa.Material-theme
MIT License
1.5k stars 290 forks source link

Add Support for C# XML documentation highlight #679

Closed digitsisyph closed 2 years ago

digitsisyph commented 2 years ago

Describe what you want

Currently, C# XML documentation would be treated as plain comments and not be highlighted.

Current bahavior: image

Desired behavior: image

Additional context

This can be easily achieved by adding following rules:

"[One Dark Pro]": {
        "textMateRules": [
            {
                    "scope": "comment.documentation",
                    "settings": {
                        "foreground": "#608B4E",
                    }
                },
                {
                    "scope": "comment.documentation.attribute",
                    "settings": {
                        "foreground": "#C8C8C8",
                    }
                },
                {
                    "scope": "comment.documentation.cdata",
                    "settings": {
                        "foreground": "#E9D585",
                    }
                },
                {
                    "scope": "comment.documentation.delimiter",
                    "settings": {
                        "foreground": "#808080",
                    }
                },
                {
                    "scope": "comment.documentation.name",
                    "settings": {
                        "foreground": "#569CD6",
                    }
                },
      ]
    }

Reference: https://github.com/OmniSharp/omnisharp-vscode/issues/3816

Binaryify commented 2 years ago

could you provide some test code

e-potashkin commented 2 years ago

Example from One Dark Pro in JetBrains Rider

Screenshot 2022-02-15 at 08 29 01
Binaryify commented 2 years ago

it's look like this now

image
digitsisyph commented 2 years ago

It looks it has been done. Thank you!