Binaryify / OneDark-Pro

Atom's iconic One Dark theme for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=zhuangtongfa.Material-theme
MIT License
1.5k stars 290 forks source link

Improve One dark pro flat by including these to the theme json file #726

Closed Tetrax-10 closed 2 years ago

Tetrax-10 commented 2 years ago

in some places, the theme is not flat. so I used to include these properties in my settings.json file. I have no idea how to make and modify using a pull request. so anyone who loves this theme make a pull request with changing these properties.

"scrollbar.shadow": "#282c34", "sideBar.border": "#282c34", "tab.activeBorder": "#b4b4b4", "statusBar.debuggingBackground": "#282C34", "statusBar.debuggingBorder": "#282C34", "statusBar.debuggingForeground": "#969aa4", "statusBar.noFolderBackground": "#282c34", "statusBarItem.warningBackground": "#282c34", "statusBarItem.warningForeground": "#b78853", "statusBarItem.remoteForeground": "#969aa4", "statusBar.border": "#282c34", "focusBorder": "#282c34",

Binaryify commented 2 years ago

could you provide some screenshots to show the different of the before and after

Tetrax-10 commented 2 years ago

one dark pro flat fix images.zip

I have Grouped them clearly one by one.

Binaryify commented 2 years ago

great~ In my opinion, I will keep the old sideBar.border color, they still need to be distinguished,and user still can custom it by themself

Binaryify commented 2 years ago

just release a new version, you can check it now~

Tetrax-10 commented 2 years ago

perfect!