Colorized Bracket Pairs support

[mciesin]

Describe what you want Starting from version 1.67.0, Colorized Bracket Pairs are enabled by default in VS Code. Colors which are used for that feature still have default values and they look off when using One Dark Pro theme.

Additional context

[julian-poidevin]

I just updated to 1.67.0 also and went right away here to request the support, default settings are not very beautiful.

[Binaryify]

I have no idea to how to make it look good, and I just close the Colorized Bracket Pairs after the vscode updated, do you have any idea?

[mciesin]

@Binaryify As far as I can tell by looking over here, there are only three levels of nesting implemented with defaults currently. I would replace the default shades of yellow, pink and blue with the colors that are defined as chalky, purple and malibu in this project, by using editorBracketHighlight.foreground1, editorBracketHighlight.foreground2 and editorBracketHighlight.foreground3.

IMO, it would make the overall look and feel much more pleasant for people willing to stay with colorized bracket pairs.

[mciesin]

You can check these values out (or some of you - leave it as a workaround) by overriding the theme's configuration in your VS Code's config file.

"workbench.colorCustomizations": {
  "[One Dark Pro]": {
    "editorBracketHighlight.foreground1": "#e5c07b",
    "editorBracketHighlight.foreground2": "#c678dd",
    "editorBracketHighlight.foreground3": "#61afef"
  }
}

[Binaryify]

yes, I know, I just don't know how to choose the best color, It's hard to strike a balance between obvious and aesthetics

[mrpunkin]

@mciesin I went ahead and just used your values in my config for now and it's world's better already. Thanks.

[mrpunkin]

Actually I went ahead and used the following instead after some further tweaking.

"workbench.colorCustomizations": {
  "[One Dark Pro]": {
    "editorBracketHighlight.foreground1": "#d19a66",
    "editorBracketHighlight.foreground2": "#c678dd",
    "editorBracketHighlight.foreground3": "#56b6c2"
  }
}

[julian-poidevin]

@mrpunkin I like your settings a lot, why don't you submit your settings as a pull request as default parameters for the theme ?

[mrpunkin]

@mrpunkin I like your settings a lot, why don't you submit your settings as a pull request as default parameters for the theme ?

I'm not familiar enough with the theme syntax for VSCode to know where those should live if they aren't simply setting overrides.

[Binaryify]

@mrpunkin it look great, I will update that

[Binaryify]

just release a new version, you can check it now~ @mrpunkin @julian-poidevin

[Binaryify]

In fact, I don't like the foreground2 color, how about set it to #abb2bf

[Tetrax-10]

In fact, I don't like the foreground2 color, how about set it to #abb2bf

These are the colors I use why don't you try these. purple is a bracket's standard color why change it. It looks nice I added #abb2bf to foreground 6

"workbench.colorCustomizations": {
    "[One Dark Pro Flat]": {
        "editorBracketHighlight.foreground1": "#E5C07B",
        "editorBracketHighlight.foreground2": "#da70d6",
        "editorBracketHighlight.foreground3": "#87cefa",
        "editorBracketHighlight.foreground4": "#f08080",
        "editorBracketHighlight.foreground5": "#00d18f",
        "editorBracketHighlight.foreground6": "#abb2bf",
    }
}

[Binaryify]

@Tetrax-10 I prefer let user custom that in their setting.json, I just pinned this issue to let people easy to find this setting

[DavidGoldman]

Is there a reason you don't want the above to be the default? I think it certainly looks better than the VS Code default (when using this theme), and users could easily change it if they want - I think it makes sense to include in the theme just to have a better default behavior.

[julian-poidevin]

Is there a reason you don't want the above to be the default? I think it certainly looks better than the VS Code default (when using this theme), and users could easily change it if they want - I think it makes sense to include in the theme just to have a better default behavior.

I totally agree ! This should be part of the default.

[vdawg-git]

@Tetrax-10 May I ask how you achieve this beautiful font style? Is this Jetbrains Mono? Have you adjusted the spacing? What are the values? :D

Also yes, this above should be part of the defaults