Binaryify / OneDark-Pro

Atom's iconic One Dark theme for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=zhuangtongfa.Material-theme
MIT License
1.5k stars 290 forks source link

Visual Studio version shows bright line below tabs #736

Closed fgimian closed 2 years ago

fgimian commented 2 years ago

Describe what you want I believe a new problem occurred recently as part of one of the Visual Studio 2022 updates and now we have a bright line just below the tab list which looks very much out of place.

Additional context image

Binaryify commented 2 years ago

plz check v1.3.2

fgimian commented 2 years ago

Thank you so much for the reply @Binaryify, I just installed v1.3.2 but sadly still see the white line below my tab bar...

image

image

Any ideas? Fotis

Binaryify commented 2 years ago

it is have some problem, I might need create an issue in the https://github.com/microsoft/theme-converter-for-vs

fgimian commented 2 years ago

it is have some problem, I might need create an issue in the https://github.com/microsoft/theme-converter-for-vs

Perhaps yeah, I have seen this issue on a few themes, but not on others, so it may be something that's triggering it in specific themes.

Binaryify commented 2 years ago

I also saw that problem in official theme image

fgimian commented 2 years ago

I also saw that problem in official theme image

That's true, though I have a feeling that may be intentional. I personally really struggle to look at the default Dark theme, it actually hurts my eyes. It has a lot of contrast everywhere so I honestly think in that particular case, it was intentional.

The older One Dark Pro theme seems to avoid this problem which is what I'm using at the moment. But that theme has been abandoned by the author and there are many other problems with it.

The complexity of theme design in Visual Studio has resulted in virtually no 3rd party theme that is 100% right sadly. 😢

Binaryify commented 2 years ago

indeed I just create an issue and you can follow this https://github.com/microsoft/theme-converter-for-vs/issues/145

fgimian commented 2 years ago

indeed I just create an issue and you can follow this microsoft/theme-converter-for-vs#145

Thank you so much for your help, really appreciate it! 🤗

Binaryify commented 2 years ago

you can check the latest version~

fgimian commented 2 years ago

Thanks so much @Binaryify, I can confirm that v1.3.3 has resolved the issue. 🥰

Really appreciate your help with this!! I'll close this issue now.

Cheers Fotis