Binaryify / OneDark-Pro

Atom's iconic One Dark theme for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=zhuangtongfa.Material-theme
MIT License
1.5k stars 290 forks source link

No syntax highlight when used with Even Better TOML #759

Closed QuarticCat closed 2 years ago

QuarticCat commented 2 years ago

See https://github.com/tamasfe/taplo/issues/276

Consider giving support.type.property-name.toml the same color as support.type.property-name.json?

Binaryify commented 2 years ago

could you provide some code

QuarticCat commented 2 years ago
[package]
name = "test"
version = "0.1.0"
Binaryify commented 2 years ago

image how about this

QuarticCat commented 2 years ago

Looks great!

Binaryify commented 2 years ago

plz check v3.15.3~

QuarticCat commented 2 years ago
[package]
name = "test"
version = "0.1.0"

authors = ["QC <QuarticCat@protonmail.com>"]
description = "this msg is only for testing"
edition = "2021"

[dependencies]
flume = "0.10.13"
serde = { version = "1.0.136", features = ["derive"] }
serde_json = "1.0.79"
tokio = { version = "1.19.2", features = ["full"] }

image

image

I'm not sure if it is Even Better TOML's problem or One Dark Pro's.

Binaryify commented 2 years ago

@QuarticCat that is semantic highlight issue, plz check v3.15.4~

QuarticCat commented 2 years ago

Here is a more comprehensive example:

# This is a TOML document

title = "TOML Example"

[owner]
name = "Tom Preston-Werner"
dob = 1979-05-27T07:32:00-08:00

[database]
enabled = true
ports = [8000, 8001, 8002]
data = [["delta", "phi"], [3.14]]
temp_targets = { cpu = 79.5, case = 72.0 }

[servers]

[servers.alpha]
ip = "10.0.0.1"
role = "frontend"

[servers.beta]
ip = "10.0.0.2"
role = "backend"

[[products]]
name = "Hammer"
sku = 738594937

[[products]]

[[products]]
name = "Nail"
sku = 284758393

color = "gray"

image

Array of tables are not colored. Besides, I enabled "editor.bracketPairColorization.enabled" but the curly brackets are not colored as well.

I didn't realize that this problem is so complex. I should have given you this example at first. Sorry for that.

The market place page of Even Better TOML has more examples. They have more kinds of colors for different data types.

QuarticCat commented 2 years ago

By the way, I personally don't mind all those keys of different data types having the same color as how they look in the default theme.

image

Binaryify commented 2 years ago

plz check the latest version

QuarticCat commented 2 years ago

Pretty nice! Thanks for your effort!