Binaryify / OneDark-Pro

Atom's iconic One Dark theme for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=zhuangtongfa.Material-theme
MIT License
1.48k stars 291 forks source link

In the theme "Nord", the "list.activeSelectionBackground" has the same color of the "list.highlightForeground". #787

Closed cfgnunes closed 1 year ago

cfgnunes commented 1 year ago

Describe the bug In the theme "Nord", the "list.activeSelectionBackground" has the same color of the "list.highlightForeground", so it's impossible to read the words in the search.

To Reproduce Steps to reproduce the behavior:

  1. In the settings, set "oneDarkPro.editorTheme": "Nord"
  2. Open the command palette (CTRL + SHIFT + P);
  3. Search any word.

Expected behavior It should be possible to read the searched word.

Desktop (please complete the following information):

Additional context

In the file src/themes/data/nord.ts, has the lines:

  'list.activeSelectionBackground': '#88c0d0',
  'list.highlightForeground': '#88c0d0',

The suggestion is to change to (to fix the problem):

  'list.activeSelectionBackground': '#88c0d0',
  'list.highlightForeground': '#d8dee9',
cfgnunes commented 1 year ago

Code merged.