search

Binaryify / OneDark-Pro

Atom's iconic One Dark theme for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=zhuangtongfa.Material-theme
MIT License
1.52k stars 289 forks source link

Change color of warning/error squiggles #96

Closed ajitid closed 7 years ago

ajitid commented 7 years ago

https://github.com/Microsoft/vscode/pull/27053

ajitid commented 7 years ago

Current colors are quite popping and do not match with the theme

Binaryify commented 7 years ago

Can you provide some screenshot?

ajitid commented 7 years ago

capture I am asking to change this red squiggle color for error. Same for warning's squiggle color.

Binaryify commented 7 years ago

What color do you think is better ?

ajitid commented 7 years ago

Same colors that are in Atom's One Dark theme

Binaryify commented 7 years ago

image

How about it ?

ajitid commented 7 years ago

This is better.

ajitid commented 7 years ago

I think warning squiggles have acceptable color, but if you think it also need to change then change it too.

ajitid commented 7 years ago

Maybe orange. Maybe.

Binaryify commented 7 years ago

image I think orange isn't a good choice

ajitid commented 7 years ago

Okay then choose the color you prefer for warning, just ensure that it goes well with the theme.

Binaryify commented 7 years ago

Will update when I resolve this issue https://github.com/Binaryify/OneDark-Pro/issues/59

Binaryify commented 7 years ago

Done ~ Please update and check it, thx ~