Binaryify / OneDark-Pro

Atom's iconic One Dark theme for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=zhuangtongfa.Material-theme
MIT License
1.52k stars 289 forks source link

Markdown bold and italics and for headings #97

Closed ajitid closed 7 years ago

ajitid commented 7 years ago

When writing markdown, bold and italic words can actually be made bold and italic. Please do that.

Binaryify commented 7 years ago

Will make italic words be italic, but fontStyle doesn't support 'bold'

ajitid commented 7 years ago

No, it does.

Nord screenshot 107

Dracula screenshot 109

OneDark Pro screenshot 108

ajitid commented 7 years ago

Maybe this is the setting for bold (pulled from Dracula):

        {
            "name": "Bold markup",
            "scope": [
                "markup.bold"
            ],
            "settings": {
                "fontStyle": "bold",
                "foreground": "#FFB86C"
            }
        },

See, font style is set to "bold"

ajitid commented 7 years ago

Please make headings bold too.

Binaryify commented 7 years ago

It doesn't a option image

ajitid commented 7 years ago

screenshot 110 I can't understand why it isn't showing in yours, but it shows in Dracula theme

Binaryify commented 7 years ago

Oh my mistake, I think it not a option but it support bold actually, will update it

ajitid commented 7 years ago

Thanks, make headings bold too.

Binaryify commented 7 years ago

ok

Binaryify commented 7 years ago

Please update and check it, thx ~