search

Binaryify / vue-custom-scrollbar

Minimalistic but perfect custom scrollbar component for Vue.JS
https://binaryify.github.io/vue-custom-scrollbar/
MIT License
145 stars 17 forks source link

Update perfect-scrollbar to ^1.5.1 to fix "Cannot read property 'scrollTop' of null" issue #68

Closed MarkParnwell closed 2 years ago

MarkParnwell commented 2 years ago

We're encountering a lot of Cannot read property 'scrollTop' of null errors (https://github.com/mdbootstrap/perfect-scrollbar/issues/835).

This was fixed in perfect-scrollbar 1.5.1 (https://github.com/mdbootstrap/perfect-scrollbar/releases/tag/1.5.1), but looking at the /dist/ of 1.4.1 published on NPM, version 1.5.0 is still bundled (like here https://github.com/Binaryify/vue-custom-scrollbar/blob/master/dist/vueScrollbar.umd.min.js#L3).

Could we bump the perfect-scrollbar version, rebuild and publish?

Thank you

Binaryify commented 2 years ago

sure

Binaryify commented 2 years ago

please check v1.4.2~

MarkParnwell commented 2 years ago

Unfortunately, it seems the distributables are still out of date on NPM and here... https://github.com/Binaryify/vue-custom-scrollbar/blob/master/dist/vueScrollbar.umd.min.js#L3 I think it needs a rebuild

Binaryify commented 2 years ago

wait

Binaryify commented 2 years ago

plz check v1.4.3

MarkParnwell commented 2 years ago

Excellent! Seems to be updated now. Now showing v1.5.3. Thank you 🙌