torbengreulich
commented
1 year ago We still have this issue and don't know why this is happening. As quick fix we did a hack to prevent our application from being blocked. We copied the ReportingServiceManager and wrapped the blocking code within downloadFileAsync as Future. With this we were able to cancel the execution after 10s.
public Future<ReportingDownloadOperation> submitDownloadAsync(ReportRequest reportRequest, AsyncCallback<ReportingDownloadOperation> callback) {
Authentication auth = authorizationData.getAuthentication();
if (auth == null) {
throw new IllegalArgumentException("Missing authentication");
}
final ResultFuture<ReportingDownloadOperation> resultFuture = new ResultFuture<ReportingDownloadOperation>(callback);
try (ExecutorService executorService = Executors.newSingleThreadExecutor()) {
var submittedFuture = executorService.submit(() -> {
final IReportingService service = serviceClient.getService();
SubmitGenerateReportRequest submitRequest = new SubmitGenerateReportRequest();
submitRequest.setReportRequest(reportRequest);
service.submitGenerateReportAsync(submitRequest, new AsyncHandler<SubmitGenerateReportResponse>() {
@Override
public void handleResponse(Response<SubmitGenerateReportResponse> res) {
try {
SubmitGenerateReportResponse response;
response = res.get();
String trackingId = ServiceUtils.GetTrackingId(res);
ReportingDownloadOperation operation = new ReportingDownloadOperation(response.getReportRequestId(), authorizationData, apiEnvironment);
operation.setTrackingId(trackingId);
operation.setStatusPollIntervalInMilliseconds(statusPollIntervalInMilliseconds);
operation.setDownloadHttpTimeoutInMilliseconds(downloadHttpTimeoutInMilliseconds);
resultFuture.setResult(operation);
} catch (InterruptedException e) {
resultFuture.setException(new CouldNotSubmitReportingDownloadException(e));
} catch (ExecutionException e) {
resultFuture.setException(new CouldNotSubmitReportingDownloadException(e));
}
}
});
});
for(int i = 1; i < 11 ; i++) {
if(submittedFuture.isDone()) {
break;
}
Thread.sleep(1000);
}
if(!submittedFuture.isDone()) {
log.warn("TimeoutException for internal call of submitGenerateReportAsync in submitDownloadAsync for {}", reportRequest.getReportName());
submittedFuture.cancel(true);
executorService.shutdownNow();
}
} catch (InterruptedException e) {
log.warn("InterruptedException for internal call of submitGenerateReportAsync in submitDownloadAsync for {}.", reportRequest.getReportName(), e);
} catch (Exception e) {
log.warn("Exception for internal call of submitGenerateReportAsync in submitDownloadAsync for {}.", reportRequest.getReportName(), e);
}
return resultFuture;
}
markusheiden
dennis-yemelyanov
We had issues with ReportingServiceManager.downloadFileAsync(). Some request did not return any answer and were blocked for days until we killed them. So we did some investigation:
This is what we call:
Unfortunately the call of
downloadFileAsync()was blocked and no future was returned, so the get with timeout could not work and we never get any response or TimeOutException.We debugged into the code and we found, that the internal call to service.submitGenerateReportAsync(submitRequest, new AsyncHandler() did not answer and through this the whole call is blocked. We were not able to check what happens inside of
submitGenerateReportAsyncbut in our opinion the call should always return the future or throw an exception.Not relevant for this issue, but here is another call that may be blocking. the
serviceClient.getService()may do some OAuthToken refreshing inrefreshOAuthTokensIfNeeded()which do some external calls, which then may be blocking. This would be another case that would block the whole downloadCall without returning any future.