HttpService: Params with cURL are not encoded

BingAds / BingAds-PHP-SDK

Other

56 stars 46 forks source link

Closed blurayne closed 6 years ago

blurayne commented 6 years ago

We had a problem with the client_secret which could be traced down to

Microsoft\BingAds\Auth\HttpService:

- $query = $query . $key . '=' . $val;
+ $query = $query . $key . '=' . rawurlencode($val);

We worked around by simply generating a client_secret without "?%" characters. But this needs to be fixed.

eric-urban commented 6 years ago

@blurayne thanks for reporting this issue! Merged here.