Update requests dependency

BingAds / BingAds-Python-SDK

Other

116 stars 162 forks source link

Update requests dependency #3

Closed kil closed 8 years ago

kil commented 9 years ago

Both setup.py and requirements.txt list requests version 2.4.3 as a requirement. That version is listed in CVE-2015-2296 (https://web.nvd.nist.gov/view/vuln/detail?vulnId=CVE-2015-2296; may not be too much of an issue for bing ads but we also use requests for a number of other things).

Can you please update the dependency to a newer version?

Viswa-Rathinavelu commented 9 years ago

Hi Kilian, Thanks for reaching out to us about this and providing the feedback. We are looking into this.

Thank you, Viswa

freiz commented 9 years ago

Hi, Kilian

We will update the version or remove the version restriction in the next release, in the mean time, you can do a workaround if our version of dependencies are blocking you, you can directly upgrade version of requests after installing bingads by typing

 pip install requests --upgrade

in your terminal, which will install the latest version of requests. And I have run a round of quick tests, this upgrade will not breaking functionality of bingads.

kil commented 9 years ago

Great, thanks!

moser commented 9 years ago

Hi, until when can we expect the next release? Cheers, Martin

Viswa-Rathinavelu commented 9 years ago

Hi Martin, Thanks for reaching out to us. We are evaluating this and we don't have an exact date planned yet for the next release. As mentioned earlier you can update the 'requests' dependency without any issues or affecting our Bing Ads python SDK functionality. Thanks again and continue providing your feedback.