BingAds / BingAds-Python-SDK

Other
117 stars 162 forks source link

Critical: SDK still not compatible with V11 #63

Closed tector closed 7 years ago

tector commented 7 years ago

On September 31 the API services for V9/V10 will be shut down - only 3 weeks to left. https://blogs.msdn.microsoft.com/bing_ads_api/2017/09/29/30-day-reminder-migrate-to-api-v11/

But this SDK is still not compatible to V11!

The problem are two hardcoded lines in the code where V9 is used instead of v11.

_bingads/reporting/reportingoperation.py on line 56: self._service_client = ServiceClient('ReportingService', authorization_data, environment, 9, **suds_options)

Change to: self._service_client = ServiceClient('ReportingService', authorization_data, environment, 11, **suds_options)

_bingads/reporting/reporting_servicemanager.py on line 39: self._service_client = ServiceClient('ReportingService', authorization_data, environment, 9, **suds_options)

Change to: self._service_client = ServiceClient('ReportingService', authorization_data, environment, 11, **suds_options)

However this is just a dirty quickfix. The used version should not be hardcoded here.

tector commented 7 years ago

Ok, it looks like i missunderstand the module structure here...

I have used from bingads.reporting import ReportingServiceManager, ReportingDownloadParameters instead of from bingads.v11.reporting import ReportingServiceManager, ReportingDownloadParameters because that was the way to use with v9 in the past and because i have to specify the version later when calling ReportingServiceManager i have not expect to change the import at all!

The bingads.reporting module should be named bingads.v9 to avoid irritations. But i guess this issue results from avoiding breaking backward compatibility.

CLOSE