search

BinghamtonRover / BurtOS-2

Base station/rover computer apps and libraries for the Binghamton University Rover Team
3 stars 0 forks source link

CAN Refactoring #66

Closed jmcmah10 closed 2 years ago

jmcmah10 commented 2 years ago

Some last second changes were made to CAN bus on the subsystem that left the codebase with some unnecessary methods, and hard to read code. These methods should be removed, and the existing code should be rewritten to be more legible and scalable.

superdan-t commented 2 years ago

The CAN socket is opened twice: https://github.com/BinghamtonRover/BurtOS-2/blob/main/src/subsystem/subsystem.cpp#L119

Not sure how that slipped by but this issue is a good place to fix it