Open timcortesi opened 3 years ago
Tagging @phelpsa as an FYI on this issue.
Fault prevention mechanism has been added to the Kernel.php and seems to be working fine. Once the all tests are done, I will commit my changes.
The most up to date code is now in the BComply environment and it seems to be working fine so far. I will post another update once we think everything is working as expected and we are ready to go live. In order for me to complete the tests, I will need to wait for Bulk Assignment to run tomorrow (at 2am or 2:30am?) as scheduled.
In app/Console/Kernel.php around like 47: We Need to confirm that $assignment->date_due is not null before continuing:
We should also look at the situations which would cause a null date_due. Is this problematic in other situations? Should this be allowable?
If date_due is null, we get the following error:
We should probably also wrap all of the code inside the module_assignment loop with a try/catch so that it will continue in the event that ANYTHING fails within the loop (around line 43):