search

BinghamtonUniversity / IAMBing

A Highly Configurable Identity & Access Management (IAM) Engine
MIT License
3 stars 0 forks source link

Username Check Needs to Fail Gracefully #2

Closed timcortesi closed 2 years ago

timcortesi commented 2 years ago

If the username check logic isn't working (external API is down or returning a failure condition), the application needs to fail in a way which isn't problematic.

Right now, it creates the person with no default username, which is the worst case scenario. It needs to either continue (ignore the external check), or do some garbage collection and delete the user if it isn't able to verify the username.

timcortesi commented 2 years ago

Currently throws an exception on line 160 of the Identity.php model:

        abort(500,'Unsupported response received from the server');
timcortesi commented 2 years ago

Addressed in this commit da8eb9c235b243d02e871fc4aead8389cad85e1f

Marking as closed / complete