BinghamtonUniversity / IAMBing

A Highly Configurable Identity & Access Management (IAM) Engine
MIT License
3 stars 0 forks source link

Add a "Download as CSV" button for the Group Action Queue #38

Closed timcortesi closed 2 years ago

timcortesi commented 2 years ago

Should include:

Action First Name Last Name Group Name Date All Unique IDs (BNumber, Millennium ID, SUNY ID) <-- This should not be hard coded, they should be dynamic based on the configuration

timcortesi commented 2 years ago

@alikemaltanriverdi

This implementation is overly complicated. This should just be a simple CSV download with a hyperlink (no Javascript)

return response($csv_data, 200)
        ->header('Content-Type', 'text/csv')
        ->header('Content-Disposition','filename="Group Action Queue '.$date.'"');

Filename should also include date and 'queue' is singular (not queues)

alikemaltanriverdi commented 2 years ago

@timcortesi Thank you for the feedback. I'll update the code make another commit.

timcortesi commented 2 years ago

Working as expected. Closed