BinkanSalaryman / Discord-Audio-Stream-Bot

A simple discord audio streaming bot.
229 stars 39 forks source link

Timeouts after joining channel #68

Closed Azahliil closed 1 year ago

Azahliil commented 1 year ago

I've been using the Discord-Audio-Stream-Bot for our Remote-TableTopRPG nights as a little bit a of a music and sound bot, and everything has been working fine until just now when I tried to start the bot, get him in a channel and play some music through it.

In the UI everything seems fine at first, until the ping seemingly randomly jumps to over 6 seconds and the bot disconnects from the channel before immediately reconnecting and repeating the loop. For the brief moments when the bot is seemingly connected there is also no audio playing from the bot as far as I can tell.

I really have no clue whatsoever why this is happening all of a sudden, but I hope someone can help me fix it :(

I atteched the app.log in hopes it may contain some useful information app.log

Azahliil commented 1 year ago

I just tried it again this morning, and apparently everything seems to be working fine again, so I assume it was discord side problem that they've fixed?

amarhany20 commented 1 year ago

same issue for me now

ODENYGG commented 1 year ago

Same. About 6000ms ping and bot loop-disconnecting and reconnecting.

KitBallard64 commented 1 year ago

Yeah. I can also attest to this lil guy having a connection issue.

Edit: Seeing some posts about Discord updating som'in to be 74 bytes instead of 70, as this hasn't been updated in a very long time. Reading here talks about it: https://github.com/Rapptz/discord.py/issues/9277#issuecomment-1450472138 Not sure if there's anything we, simple users can do outside waiting for BinkanSalaryman, or one of the other contribs.

bobeckert commented 1 year ago

Similarly confirmed. I am experiencing the same issue.

I wish I had older log files to compare to. I am seeing CFRayID and I do not remember seeing this previously. This is making me wonder if Discord has recently changed to start using Cloudflare?

KitBallard64 commented 1 year ago

Similarly confirmed. I am experiencing the same issue.

I wish I had older log files to compare to. I am seeing CFRayID and I do not remember seeing this previously. This is making me wonder if Discord has recently changed to start using Cloudflare?

Not sure. I think this goes in hand with the thread I linked, as that thread started the same time frame as this one's OP did. And said it went away after a bit for them. So I'm personally leaning towards that thread as a possible avenue to look into.

pgDora56 commented 1 year ago

Same. I don't know much about this program, but I think it has to do with time.

Here are the results of my trial (All time are GMT):

In my case, when not available, it remained not available for a while.

amarhany20 commented 1 year ago

well yeah I tested more than one pc, more than one discord bot, more than one server. same 6000ms. and if you have the same problem then, there is something that discord did that affected the bot.

Atis9 commented 1 year ago

I made the following modifications and built it and it worked. (Windows 11 64bit, Java 17)

diff --git a/build.gradle b/build.gradle
index fd664f5..17c1a67 100644
--- a/build.gradle
+++ b/build.gradle
@@ -1,7 +1,7 @@
 plugins {
     id 'java'
     id 'application'
-    id "com.github.johnrengelman.shadow" version "5.2.0"
+    id "com.github.johnrengelman.shadow" version "8.1.1"
 }

 group 'net.runee'
@@ -20,7 +20,7 @@ repositories {
 }

 dependencies {
-    implementation "net.dv8tion:JDA:4.3.0_291"
+    implementation "net.dv8tion:JDA:4.4.1_353"
 //    implementation "com.sedmelluq:lavaplayer:1.3.42"
     implementation "com.jgoodies:jgoodies-forms:1.9.0"
     implementation "com.jgoodies:jgoodies-common:1.8.1"

I made a Docker-enabled patch to make building easier, so please feel free to use it.

Discord-Audio-Stream-Bot.patch

KitBallard64 commented 1 year ago

I made a Docker-enabled patch to make building easier, so please feel free to use it.

Discord-Audio-Stream-Bot.patch

Nice but uh... I don't get it.

Sylvache commented 1 year ago

I made a Docker-enabled patch to make building easier, so please feel free to use it. Discord-Audio-Stream-Bot.patch

Nice but uh... I don't get it.

Same :/

BinkanSalaryman commented 1 year ago

Big thanks to @Atis9, currently working on updating the libraries / integrating the patch. Works great so far, just trying to get a few minor things done before I push the changes and release a new version. And sorry that I let you wait guys :/

BinkanSalaryman commented 1 year ago

The new release should have fixed the issue.

BillyNat commented 1 year ago

Hey, thank you for updating the bot!

Unfortunately, I can't open the bat file. When I try to execute it, I get "Error: Could not create the Java Virtual Machine Error: A fatal exception has occurred. Program will exit." And if I try with executing it as an Admin, I get: "Error: Unable to access jarfile Discord Audio Stream Bot.jar"

I'm sorry, I'm such a nooby as far as this is all concerned, can anyone help?

Sylvache commented 1 year ago

The new release should have fixed the issue.

Would it be possible to have a new download link plz ? The latest available is: Latest build (2021-07-03)

BinkanSalaryman commented 1 year ago

Would it be possible to have a new download link plz ? The latest available is: Latest build (2021-07-03)

Can't confirm:

image

BinkanSalaryman commented 1 year ago

Hey, thank you for updating the bot!

Unfortunately, I can't open the bat file. When I try to execute it, I get "Error: Could not create the Java Virtual Machine Error: A fatal exception has occurred. Program will exit." And if I try with executing it as an Admin, I get: "Error: Unable to access jarfile Discord Audio Stream Bot.jar"

I'm sorry, I'm such a nooby as far as this is all concerned, can anyone help?

Try updating your java to at least jre8, see #67

Sylvache commented 1 year ago

Would it be possible to have a new download link plz ? The latest available is: Latest build (2021-07-03)

Can't confirm:

image

Arf i'm stupid :/ Thanks haha

Wraithage commented 1 year ago

Try updating your java to at least jre8, see #67

Thanks for staying with us on this. I updated to Java current release, 8u361, and also unblocked the .jar file. Unfortunately, I'm still seeing the same errors as BillyNat.

java security

image

BillyNat commented 1 year ago

I've tried updating Java to 8, didn't work. Then I installed the Java SE dev kit 17, then it worked!

Thanks!

BinkanSalaryman commented 1 year ago

I updated to Java current release, 8u361, and also unblocked the .jar file. Unfortunately, I'm still seeing the same errors

Well, I'm sorry but I still have no clue why it sometimes does this. But the errors are related to java in general and not this software in particular. There are plenty articles on the web about those, and hopefully, if you dig enough, you will find a way that works for you.

May be it doesn't work for java version 8 because I added the line "--add-exports" thing for java v9+ modules quite a while back.

Wraithage commented 1 year ago

I updated to Java current release, 8u361, and also unblocked the .jar file. Unfortunately, I'm still seeing the same errors

Well, I'm sorry but I still have no clue why it sometimes does this. But the errors are related to java in general and not this software in particular. There are plenty articles on the web about those, and hopefully, if you dig enough, you will find a way that works for you.

May be it doesn't work for java version 8 because I added the line "--add-exports" thing for java v9+ modules quite a while back.

Not to worry, I'm just reporting. Again, we all appreciate you looking at it.

But I can confirm what BillyNat said above, except that I installed JDK 20 instead of 17. It's working once that's in. So there's obviously some difference between the java executables in the JRE and the JDK.

Thanks again!

BinkanSalaryman commented 1 year ago

@Sylvache I realized it's partially my fault for not updating the README.md file, while updating it because I saw it was quite dated already. Sorry for that!

KitBallard64 commented 1 year ago

Just wanted to confirm that it looks like the issue is solved on my side. Thank you again~♥