search

BinomialLLC / basis_universal

Basis Universal GPU Texture Codec
Apache License 2.0
2.72k stars 267 forks source link

The transcoder & the KDFS do not agree on the ETC1S flip bit #254

Closed lexaknyazev closed 2 years ago

lexaknyazev commented 3 years ago

From the KDFS:

Finally, the flip bit is encoded as 0 — the subsets are identical anyway.

Source code here: https://github.com/BinomialLLC/basis_universal/blob/b993de420914a9f710e02655ccda6a20ee3112d6/transcoder/basisu_transcoder.cpp#L7983

/cc @fluppeteer @MarkCallow

richgel999 commented 3 years ago

This slipped between the cracks. It shouldn't matter to Basis Universal - so I can disable it on my end.

richgel999 commented 3 years ago

I have fixed this in our latest development version (v1.16). It'll go out when this is release (Dec./Jan.).