BinomialLLC / basis_universal

Basis Universal GPU Texture Codec
Apache License 2.0
2.72k stars 267 forks source link

Transcode failure on iOS 17 #358

Open slimbuck opened 1 year ago

slimbuck commented 1 year ago

I am raising this for visibility and in hopes others have found a solution.

Our users are reporting random failures of basis transcode on iOS 17.0.

It looks likely a regression in safari, I have reported the issue here:

https://bugs.webkit.org/show_bug.cgi?id=260252

Since iOS 17 is now released we may be forced to find a workaround.

slimbuck commented 1 year ago

Having test a little more, it's the call to file.transcodeImage on the final/smallest mipmap level which fails:

To reiterate, these failures are likely to be an issue with Safari 17 WASM engine, but we are trying to find a possible mitigation from our end.

Ben-Mack commented 1 year ago

Seem like you have found workaround for this problem: https://forum.playcanvas.com/t/important-basis-on-safari-17-0/33145

We found that recompiling the basis module with the latest emscripten toolchain seems to mitigate the issue

@richgel999 Can you update a version compiled with latest emscripten toolchain?

richgel999 commented 11 months ago

@richgel999 Can you update a version compiled with latest emscripten toolchain?

Yes - no problem.