Fix issue preventing graceful Unraid shutdown.

[Torqu3Wr3nch]

Resolves #28 by lazily unmounting Rclone and mergerfs mounts.

[BinsonBuzz]

Thanks. I run this script at array start.

Would the new commands work if multiple mounts are present?

[Torqu3Wr3nch]

I do the same, but I actually have a second copy of the script to run at array stop. (I actually would recommend this configuration for anyone. Let me know if you would like me to make such an update to the readme).

This updated script should work assuming users configured it for each additional rclone mount.

[BinsonBuzz]

I do the same, but I actually have a second copy of the script to run at array stop. (I actually would recommend this configuration for anyone. Let me know if you would like me to make such an update to the readme).

This updated script should work assuming users configured it for each additional rclone mount.

Is there anyway to make it work globally so only one instance is needed like currently? If not, it might be something to add in the comments as an optional tweak.

In fact, let's do that for now - can you add a comment line saying something like "....this only works if you have one mount instance. If you have multiple rclone mounts, add manual entries for each mount"

[Torqu3Wr3nch]

I can look into it- I'm 90% sure umount allows for multiple mount points. Do you have an example mount script configuration that I can look at for multiple mount points or are users just creating multiple mount scripts for each rclone mount?

Side note outside of the scope of this pull request, when I wrote this script, I considered centralizing where we store the "required settings" since different scripts pull from the same information. This would decrease the risk of transcription errors among users, but that's for another time.

I'll update the comments for the time being. It's already broken now, so the quick fix is what I want to prioritize for the time being.

If you're agreeable to the idea of a centralized "required settings" config file, I can look at implementing that alongside the umount for multiple mount points. Makes sense to do them together.

[BinsonBuzz]

All good suggestions.

The reasons I have the settings in each script, is I think users with multiple mounts create multiple instances of the script i.e. one per mount, one per upload etc

On Tue, 21 Sept 2021 at 14:28, Torqu3Wr3nch @.***> wrote:

I can look into it- I'm 90% sure umount allows for multiple mount points. Do you have an example mount script configuration that I can look at for multiple mount points or are users just creating multiple mount scripts for each rclone mount?

Side note outside of the scope of this pull request, when I wrote this script, I considered centralizing where we store the "required settings" since different scripts pull from the same information. This would decrease the risk of transcription errors among users, but that's for another time.

I'll update the comments for the time being. It's already broken now, so the quick fix is what I want to prioritize for the time being.

If you're agreeable to the idea of a centralized "required settings" config file, I can look at implementing that alongside the umount for multiple mount points. Makes sense to do them together.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/BinsonBuzz/unraid_rclone_mount/pull/30#issuecomment-923990479, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF6KLGN63IHHH3LWXPMTJALUDCCBRANCNFSM5EMPGQSA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

[Torqu3Wr3nch]

Comments updated.