search

BioAnalyticResource / ePlant

ePlant is a gene-centric visualization tool for plant genomes
https://bioanalyticresource.github.io/ePlant/
GNU General Public License v2.0
7 stars 12 forks source link

Chromosome view yonah #131

Closed y330 closed 3 months ago

y330 commented 4 months ago

For yukthi to look at: Eplant/views/ChromosomeViewer/Viewer/GeneList.Tsx Line 111

Yukthiw commented 3 months ago

@y330 Thanks for addressing most of the comments, just a couple things before we get to merging this.

If you could move the helper functions in Chromosome.tsx to another file ("utils.tsx" or whatever) that would help with readability a lot.

I made a comment about how we are handling the fetching of gene data, right now we are making a ton of api requests every time a new gene is added. Cutting down on these should improve performance by a lot but I think this can be left for another PR, just leave the comment there for reference.

Finally, before merging run npx prettier Eplant --write and push the changes to fix formatting issues (in the future adding the format on save feature to your vscode makes things easy)

y330 commented 3 months ago

@Yukthiw I moved the helper functions to a new file, and ran npx prettier Eplant --write. I am still not a contributor yet, so i cannot merge the PR