BioArchLinux / Packages

Aim to be the bioinformatics repository with more and newer packages
https://bioarchlinux.org/packages
GNU Affero General Public License v3.0
82 stars 9 forks source link

snapgene-viewer: Add package #203

Closed Kiri2002 closed 6 months ago

Kiri2002 commented 7 months ago

Involved packages

Involved issue

Add package

Close #

Details

Additional Note

tested in extra-x86_64:

snapgene-viewer

The ELF error caused by upstream can't be fixed. This is a close source software like mega.

Kiri2002 commented 7 months ago

The original .so files and snapgene(bin) has wrong rpath forward to "/home/centos", example:

snapgene E: Insecure RPATH '/home/centos/.conan/data/qt-for-sg/6.2.10/snapgene/stable/package/f6a1919c5d86e9463ebddc2f3d4066e8e92eadce/lib' in file ('opt/gslbiotech/snapgene/libqntp.so.1.0.0')
snapgene E: Insecure RPATH '/home/centos/.conan/data/qt-for-sg/6.2.10/snapgene/stable/package/f6a1919c5d86e9463ebddc2f3d4066e8e92eadce/lib' in file ('opt/gslbiotech/snapgene/libqwebdavlib.so.1.0.0')

So I use "patchelf" to fix it.

starsareintherose commented 7 months ago

why it creates centos home dir?

starsareintherose commented 7 months ago

@hubutui @lilydjwg @pekkarr would you like to give a review for this pr

Kiri2002 commented 7 months ago

The "rpath" mean "run path", is parameter for .so or executable bin etc. It will try to access to "rpath" to find libs when run.

why it creates centos home dir?

It not create any dir. And why some file have wrong rpath, the upstream should be blamed who built it in wrong way.

how about creating a install file?

I searched in Archlinuxcn, and don't find any example to fix rpah in install/patch file. But in PKGBUILD.

https://github.com/search?q=repo%3Aarchlinuxcn%2Frepo%20patchelf&type=code

Kiri2002 commented 7 months ago

@starsareintherose There are more information about "rpath": https://en.wikipedia.org/wiki/Rpath https://bugs.archlinux.org/task/14049

starsareintherose commented 7 months ago

If @lilydjwg agree, we are delighted to merge it

hubutui commented 7 months ago

Is this pkg free software? Could we redistribute it?

starsareintherose commented 7 months ago

It seems that this pkg is commercial one.

Kiri2002 commented 7 months ago

Just like mega

starsareintherose commented 7 months ago

@hubutui but it's a bit different from mega, mega is free of charge, snapgene needs payment

Kiri2002 commented 7 months ago

image

Both them can download without money. But snapgene need license(can try for free for some days). While snapgene-viewer need no payment.

Kiri2002 commented 7 months ago

image

Should the ms-font be added to opt-depends? It use system font now, and work fine

Kiri2002 commented 7 months ago

sorry for forget upload *.sh. Added now

hubutui commented 7 months ago

could you check the source again?

 updpkgsums
==> Retrieving sources...
  -> Downloading snapgene_7.2.0_linux.rpm...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (56) The requested URL returned error: 404
==> ERROR: Failure while downloading https://cdn.snapgene.com/downloads/SnapGene/7.x/2/7.2.0/snapgene_7.2.0_linux.rpm
    Aborting...
==> ERROR: Failed to generate new checksums

==> Retrieving sources...
  -> Downloading snapgene_viewer_7.2.0_linux.rpm...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (56) The requested URL returned error: 404
==> ERROR: Failure while downloading https://cdn.snapgene.com/downloads/SnapGeneViewer/7.x/2/7.2.0/snapgene_viewer_7.2.0_linux.rpm
    Aborting...
==> ERROR: Failed to generate new checksums
hubutui commented 7 months ago

you can follow this wiki to build this pkg in a clean chroot.

Kiri2002 commented 7 months ago

could you check the source again?

 updpkgsums
==> Retrieving sources...
  -> Downloading snapgene_7.2.0_linux.rpm...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (56) The requested URL returned error: 404
==> ERROR: Failure while downloading https://cdn.snapgene.com/downloads/SnapGene/7.x/2/7.2.0/snapgene_7.2.0_linux.rpm
    Aborting...
==> ERROR: Failed to generate new checksums

==> Retrieving sources...
  -> Downloading snapgene_viewer_7.2.0_linux.rpm...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (56) The requested URL returned error: 404
==> ERROR: Failure while downloading https://cdn.snapgene.com/downloads/SnapGeneViewer/7.x/2/7.2.0/snapgene_viewer_7.2.0_linux.rpm
    Aborting...
==> ERROR: Failed to generate new checksums

this issue cause by this: image

now fixed.

starsareintherose commented 7 months ago

image

Should the ms-font be added to opt-depends? It use system font now, and work fine

It doesn't make sense, some commercial software is free to use, but they don't want us to re-distribute it

Kiri2002 commented 7 months ago

image Should the ms-font be added to opt-depends? It use system font now, and work fine

It doesn't make sense, some commercial software is free to use, but they don't want us to re-distribute it

Maybe just do it, remove when the vendor ask us to do.

starsareintherose commented 7 months ago

@hubutui final check, then you can squash and merge

starsareintherose commented 6 months ago

Final decision: only snapegene-viewer can be merged

Kiri2002 commented 6 months ago

Final decision: only snapegene-viewer can be merged

snapgene separated to https://github.com/BioArchLinux/Packages/pull/204, for maybe something changed in the future.