BioContainers / containers

Bioinformatics containers
http://biocontainers.pro
Apache License 2.0
689 stars 249 forks source link

Manage tagging of software versions #156

Closed osallou closed 6 years ago

osallou commented 7 years ago

tagging an image with "+" character is not allowed (as well as a few others I think)

There are such characters in debian versions (but not only).

So we need to trick those when tagging (could replace for example + by - (to be discussed on special char and rules for modification).

However, to match a container image vs its Dockerfile, we maybe also modify the version in Dockerfile

ypriverol commented 7 years ago
bgruening commented 7 years ago

@ypriverol yes the conda naming schema of packages.

ypriverol commented 7 years ago

Can you point me to the documentation.

bgruening commented 7 years ago

https://conda.io/docs/building/pkg-name-conv.html

osallou commented 7 years ago

Examples quite frequent found in debian: aegean/0.15.2+dfsg-1, aevol/4.4-1+b4, biosquid-dev/1.9g+cvs20050121-7 Behind the "-", this is debian related, before it is upstream related

osallou commented 7 years ago

@bgruening this link does not specify contraining rules regarding version naming. "+" and others are forbidden on DockerHub Link only specifies: "A version number or string, often similar to X.Y or X.Y.Z, but may take other forms as well"

We need to map versions like "1.9g+cvs20050121-7" to a Docker enabled version.

osallou commented 7 years ago

base image uploaded, now remains version tagging issue and I can push my Dockerfiles and build images before pushing them to dockerhub like biocontainers/softwarename:debian-XXX