BioContainers / containers

Bioinformatics containers
http://biocontainers.pro
Apache License 2.0
680 stars 247 forks source link

Added procps to ncbi-tools-bin Dockerfile #542

Closed eeaunin closed 11 months ago

eeaunin commented 11 months ago

Hello. The current ncbi-tools-bin BioContainers Docker image (made from https://github.com/BioContainers/containers/blob/master/ncbi-tools-bin/6.1.20170106-6-deb/Dockerfile ) doesn't work with nf-core pipelines. The error that I get when trying to use it in an nf-core pipeline is this: Command 'ps' required by nextflow to collect task metrics cannot be found. I think this means that procps (which provides ps) needs to be installed and in path inside the image in order for the image to work with Nextflow when using the Docker profile. I am proposing adding the installation of procps to the Dockerfile

mboudet commented 11 months ago

Hi. Several things:

Might be some other things to modify, since this is an old package and the Dockerfile format might have changed since them. I'll run the tests once you have made the changes.

eeaunin commented 11 months ago

Hello, I made the requested changes now. I tested building the dockerfile, it works for me

biocontainers-bot commented 11 months ago

about.license field is not in spdx list: https://spdx.org/licenses/, if it is a typo error, please fix it. If this is not a standard license, please specify Custom License and use about.license_file label to specify license location (in container or url).

biocontainers-bot commented 11 months ago

No biotools label defined, please check if tool is not already defined in biotools (https://bio.tools) and add extra.identifiers.biotools label if it exists. If it is not defined, you can ignore this comment.

biocontainers-bot commented 11 months ago

No test-cmds.txt (test file) present, skipping tests

mboudet commented 11 months ago

Ok. You just need to change the 'software.version' to '6.1.20170106+dfsg1-0+deb10u2', and about.license_file to 'Custom license', and I should be able to merge it.

eeaunin commented 11 months ago

I've done this now. Although, are you sure that about.license_file and not about.license needed to be changed to Custom license?

mboudet commented 11 months ago

You're right, sorry about that, I copied the wrong key. You can set 'about.license' to 'Custom license', and keep the previous value for 'about.license_file'

eeaunin commented 11 months ago

I've made this change now

biocontainers-bot commented 11 months ago

software.version label not matching directory version name

biocontainers-bot commented 11 months ago

about.license field is not in spdx list: https://spdx.org/licenses/, if it is a typo error, please fix it. If this is not a standard license, please specify Custom License and use about.license_file label to specify license location (in container or url).

biocontainers-bot commented 11 months ago

No biotools label defined, please check if tool is not already defined in biotools (https://bio.tools) and add extra.identifiers.biotools label if it exists. If it is not defined, you can ignore this comment.

mboudet commented 11 months ago

Sorry about that. Should be actually ok after this.

biocontainers-bot commented 11 months ago

about.license field is not in spdx list: https://spdx.org/licenses/, if it is a typo error, please fix it. If this is not a standard license, please specify Custom License and use about.license_file label to specify license location (in container or url).

biocontainers-bot commented 11 months ago

No biotools label defined, please check if tool is not already defined in biotools (https://bio.tools) and add extra.identifiers.biotools label if it exists. If it is not defined, you can ignore this comment.

biocontainers-bot commented 11 months ago

No test-cmds.txt (test file) present, skipping tests

biocontainers-bot commented 11 months ago

No biotools label defined, please check if tool is not already defined in biotools (https://bio.tools) and add extra.identifiers.biotools label if it exists. If it is not defined, you can ignore this comment.

biocontainers-bot commented 11 months ago

No test-cmds.txt (test file) present, skipping tests

mboudet commented 11 months ago

Merging, thanks for your patience.

eeaunin commented 11 months ago

Thanks a lot!