search

BioContainers / containers

Bioinformatics containers
http://biocontainers.pro
Apache License 2.0
674 stars 246 forks source link

Dask container recipe #545

Closed cgoina closed 9 months ago

cgoina commented 9 months ago

Submitting a Container

(If you're requesting for a new container, please check the procedure described here.

Check BioContainers' Dockerfile specifications

Checklist

  1. Misc

    • [ ] My tool doesn't exist in BioConda
    • [ ] The image can be built

  2. Metadata

    • [ ] LABEL base_image
    • [ ] LABEL version
    • [ ] LABEL software.version
    • [ ] LABEL about.summary
    • [ ] LABEL about.home
    • [ ] LABEL about.license
    • [ ] MAINTAINER

  3. Extra (optionals)

    • [ ] I have written tests in test-cmds.txt
    • [ ] LABEL extra.identifier
    • [ ] LABEL about.documentation
    • [ ] LABEL about.license_file
    • [ ] LABEL about.tags

    Check BioContainers' Dockerfile metadata

cgoina commented 9 months ago

This container contains scripts that we use in our nextflow dask workflow, which we intend to submit to nf-core.

cgoina commented 9 months ago

I made the change to chmod in a separate step

biocontainers-bot commented 9 months ago

software.version label not matching directory version name

biocontainers-bot commented 9 months ago

Could not find the defined biotools entry, please check its name on biotools

cgoina commented 9 months ago

I saw the failure "Found some errors: software.version label not matching directory version name" - I named the folder based on the dask version, python version and os version - should I include all these in the software.version label? The current software version label is only showing the dask version

cgoina commented 9 months ago

I updated the software.version label to reflect the dir name

biocontainers-bot commented 9 months ago

Could not find the defined biotools entry, please check its name on biotools

biocontainers-bot commented 9 months ago

No test-cmds.txt (test file) present, skipping tests

mboudet commented 9 months ago

Ok, you should just remove the extra.identifiers.biotools="dask" , since I don't think it exists in biotools ?

biocontainers-bot commented 9 months ago

No biotools label defined, please check if tool is not already defined in biotools (https://bio.tools) and add extra.identifiers.biotools label if it exists. If it is not defined, you can ignore this comment.

biocontainers-bot commented 9 months ago

No test-cmds.txt (test file) present, skipping tests

mboudet commented 9 months ago

Seems fine to me, merging.