Closed eliasball closed 4 months ago
Hey!
One more thing before the PR could potentially be accepted: As mentioned above, to build the image, --ulimit nofile=262144:262144
needs to provided to docker build
. How should this be done in Biocontainers?
Also, the software provided is not my software, but I forked the repo and added some important files to make the docker container build. Is it alright to provide only the links to my fork in the LABELS?
about.license field is not in spdx list: https://spdx.org/licenses/, if it is a typo error, please fix it. If this is not a standard license, please specify Custom License and use about.license_file label to specify license location (in container or url).
No biotools label defined, please check if tool is not already defined in biotools (https://bio.tools) and add extra.identifiers.biotools label if it exists. If it is not defined, you can ignore this comment.
No test-cmds.txt (test file) present, skipping tests
Hmm, it seems to build fine on our end without the --ulimit. (Which is great, because there are not easy way to include those in the build process).
Not sure regarding the fork. Is the maintainer not interested in merging your modifications in the main repo?
I see, this is good news! The --ulimit was related to a bug when installing cudatoolkit (https://github.com/mamba-org/mamba/issues/2501#issuecomment-1582182711) and the fix simply requires it to be not set too high. Great that it works without on our build system!
Regarding the fork: I haven't contacted the maintainer about this topic, as it was simpler to just devise the necessary env.yml file myself and have control over release versioning. If this is wished for I could do this however.
Well, I feel like it would be cleaner to link to the main repo. If the maintainer does not wish to incorporate the modifications, we can proceed as it is.
Alright, I will open a PR for the main repo and contact the maintainer, I will reach out once everything works, thanks a lot! :)
Submitting a Container
Checklist
Misc
--ulimit nofile=262144:262144
needs to provided todocker build
. How should this be done in Biocontainers?Metadata
Extra (optionals)