BioContainers / containers

Bioinformatics containers
http://biocontainers.pro
Apache License 2.0
674 stars 246 forks source link

new rsat version 20240507, tested in local Docker #570

Closed eead-csic-compbio closed 3 months ago

eead-csic-compbio commented 4 months ago

This PR adds a new version of the Docker BioContainer with the RSAT software, which now ships wit the code corresponding to tag 20240507 in source repo (https://github.com/rsa-tools/rsat-code). Accordingly, the Dockerfile now contains LABEL software.version="20240507".

The two main updates are:

Example non-interactive calls would be:

docker run -v $PWD:/home/rsat_user -v $PWD/out:/home/rsat_user/out rsat:20240507 peak-motifs -i test.fa -outdir out -prefix test

docker run -v $PWD:/home/rsat_user -v $PWD/out:/home/rsat_user/out rsat:20240507 peak-motifs -i test.fa -outdir out -prefix test -motif_db footDB transfac /packages/rsat/public_html/motif_databases/footprintDB/footprintDB.plants.motif.tf

Note the examples require binding two folders:

  1. The current folder from where the container is called ($PWD). This allows processing any FASTA file in the current directory.
  2. The folder to save the results (out/). This should point to an existing local folder where anybody can write (chmod 777).

@medinaale @morganeTC @najlaksouri

eead-csic-compbio commented 4 months ago

Hi @ievarau, please use this PR to add any comments you might have during your tests

ievarau commented 4 months ago

All in all, peak-motifs with this container version works as expected.

biocontainers-bot commented 4 months ago

No test-cmds.txt (test file) present, skipping tests

eead-csic-compbio commented 4 months ago

This PR is read y to be reviewed by somebody from BioContainers, thanks

eead-csic-compbio commented 3 months ago

Hi @mboudet , please let us know if there's anything you need from us

mboudet commented 3 months ago

Sorry for the delay, last week was mostly bank holidays here.

One quick question: any reason for installing git in a separate apt-get install step? (Ie line 91 instead of 43) (This is not blocking, just for curiosity).

eead-csic-compbio commented 3 months ago

Sorry for the delay, last week was mostly bank holidays here.

One quick question: any reason for installing git in a separate apt-get install step? (Ie line 91 instead of 43) (This is not blocking, just for curiosity).

I guess it was to make it clear that the installation of RSAT would be done using git

mboudet commented 3 months ago

Alright. Thank you for your contribution.