BioDynaMo / biodynamo

BioDynaMo is a high-performance and modular, agent-based simulation platform.
Apache License 2.0
101 stars 46 forks source link

macOS builds GHA can't find Paraview SHA #397

Open imorlxs opened 2 months ago

imorlxs commented 2 months ago

Describe the bug In GHA build (macos-14), in the Build BioDynaMo step, CMake try to call download_verify_extract function without the SHA. This causes a CMake error. Somehow CMake can't find the SHA. I found this error in #379 and #390. This PRs don't touch anything about that function, so I don't know why it happens.

Screenshots `-- Could NOT find ParaView (missing: ParaView_DIR)

########################### WARNING ############################

We did not find any ParaView installed on the system. We will proceed to download it. ParaView will be installed in the location /Users/runner/work/biodynamo/biodynamo/build/third_party/paraview. Using brew Qt5 in /opt/homebrew/opt/qt@5/lib/cmake/Qt5 for ParaView.

################################################################

################################################################

-- Using ParaView tarball : paraview_v5.10.0_osx-14.6-arm64_default.tar.gz CMake Error at cmake/external/ParaView.cmake:22 (download_verify_extract): download_verify_extract Function invoked with incorrect arguments for function named: download_verify_extract Call Stack (most recent call first): CMakeLists.txt:402 (include)

-- Using ParaView source dir : /Users/runner/work/biodynamo/biodynamo/build/third_party/paraview -- Using ParaView SHA key : osx-14.6-arm64-ParaView -- Verify ParaView SHA : `

As you can see, the CMake didn't find the SHA.

FonsRademakers commented 2 months ago

Hi Isaac,

Could you merge the master in your branch to fix this.

Cheers, Fons.

On 20 Sep 2024, at 17:45, Isaac Morales Santana @.***> wrote:

Describe the bug In GHA build (macos-14), in the Build BioDynaMo step, CMake try to call download_verify_extract function without the SHA. This causes a CMake error. Somehow CMake can't find the SHA. I found this error in #379 and #390. This PRs don't touch anything about that function, so I don't know why it happens. Screenshots -- Could NOT find ParaView (missing: ParaView_DIR) ########################### WARNING ############################ We did not find any ParaView installed on the system. We will proceed to download it. ParaView will be installed in the location /Users/runner/work/biodynamo/biodynamo/build/third_party/paraview. Using brew Qt5 in ***@***.***/lib/cmake/Qt5 for ParaView. ################################################################ ################################################################ -- Using ParaView tarball : paraview_v5.10.0_osx-14.6-arm64_default.tar.gz CMake Error at cmake/external/ParaView.cmake:22 (download_verify_extract): download_verify_extract Function invoked with incorrect arguments for function named: download_verify_extract Call Stack (most recent call first): CMakeLists.txt:402 (include) -- Using ParaView source dir : /Users/runner/work/biodynamo/biodynamo/build/third_party/paraview -- Using ParaView SHA key : osx-14.6-arm64-ParaView -- Verify ParaView SHA : As you can see, the CMake didn't find the SHA. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- Dr. Fons Rademakers Senior Scientist CERN - European Organization for Nuclear Research