search

BioImage-Archive / bia-integrator

Apache License 2.0
2 stars 3 forks source link

Print summary of models created/errors when creating image representations #211

Closed kbab closed 19 hours ago

kbab commented 1 day ago

This PR attempts to print a summary of models created and/or errors encountered when creating image representations. However, the output generated is not strictly correct - as only one Experimentally Captured Image (ECI) is created for all representations of the same file reference uuid(s). However, the current code logs creation of an ECI for each representation - thus overstating the number of ECIs created.

kbab commented 1 day ago

Two small comments on these changes, but otherwise would be okay with approving this, despite the issue with the miscounted ECIs....

I have more fundamental issues with how this part of the cli is set up (which is think the miscounting is a symptom of), but i think these should be addressed in a separate ticket to refactor the code. Namely:

  1. The cli command seems to be set up differently to the ingest command, as if it will be about creating various different objects, but then the logic is only (currently) very specific to image representations - and i don't see us needing it for other things.
  2. Despite being all about creating representations it also is the only way to create the abstract images, which isn't obvious from the cli code.

Happy to discuss and create new clickup ticket to address these.