search

BioJulia / Automa.jl

A julia code generator for regular expressions
Other
188 stars 15 forks source link

Enforce action dict symbols are same as machines #101

Closed jakobnissen closed 2 years ago

jakobnissen commented 2 years ago

Before this PR, a user could forget or mis-spell a symbol in the action Dict passed to generate_exec_code. Now add a check to throw an error if this happens.

codecov[bot] commented 2 years ago

Codecov Report

Merging #101 (bfdbcd7) into master (69d16f5) will increase coverage by 0.18%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #101      +/-   ##
==========================================
+ Coverage   90.76%   90.94%   +0.18%     
==========================================
  Files          16       16              
  Lines        1808     1822      +14     
==========================================
+ Hits         1641     1657      +16     
+ Misses        167      165       -2
Flag Coverage Δ
unittests 90.94% <100.00%> (+0.18%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/codegen.jl 91.78% <100.00%> (+0.18%) :arrow_up:
src/machine.jl 77.55% <100.00%> (+4.71%) :arrow_up:
src/precond.jl 86.36% <0.00%> (+2.27%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 69d16f5...bfdbcd7. Read the comment docs.

jakobnissen commented 2 years ago

This change is technically breaking. Downstream tests reveal that this actually does break two dependencies, so I'll move this to the v1 PR.