BioJulia / Automa.jl

A julia code generator for regular expressions
Other
188 stars 15 forks source link

Breaking changes for v1 #119

Closed jakobnissen closed 1 year ago

jakobnissen commented 1 year ago

Supersedes #95

Todo

Closes #52 Closes #71 Closes #80 Closes #82 Closes #91 Closes #102 Closes #111 Closes #115 Closes #116

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 94.75% and project coverage change: +6.50 :tada:

Comparison is base (3b5c913) 89.48% compared to head (fe0feb1) 95.98%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #119 +/- ## ========================================== + Coverage 89.48% 95.98% +6.50% ========================================== Files 14 16 +2 Lines 1683 1793 +110 ========================================== + Hits 1506 1721 +215 + Misses 177 72 -105 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `95.98% <94.75%> (+6.50%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BioJulia#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://app.codecov.io/gh/BioJulia/Automa.jl/pull/119?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BioJulia) | Coverage Δ | | |---|---|---| | [src/action.jl](https://app.codecov.io/gh/BioJulia/Automa.jl/pull/119?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BioJulia#diff-c3JjL2FjdGlvbi5qbA==) | `97.43% <ø> (ø)` | | | [src/dot.jl](https://app.codecov.io/gh/BioJulia/Automa.jl/pull/119?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BioJulia#diff-c3JjL2RvdC5qbA==) | `95.78% <ø> (ø)` | | | [src/precond.jl](https://app.codecov.io/gh/BioJulia/Automa.jl/pull/119?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BioJulia#diff-c3JjL3ByZWNvbmQuamw=) | `84.09% <ø> (ø)` | | | [src/codegen.jl](https://app.codecov.io/gh/BioJulia/Automa.jl/pull/119?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BioJulia#diff-c3JjL2NvZGVnZW4uamw=) | `91.69% <87.50%> (+0.10%)` | :arrow_up: | | [src/workload.jl](https://app.codecov.io/gh/BioJulia/Automa.jl/pull/119?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BioJulia#diff-c3JjL3dvcmtsb2FkLmps) | `89.47% <89.47%> (ø)` | | | [src/re.jl](https://app.codecov.io/gh/BioJulia/Automa.jl/pull/119?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BioJulia#diff-c3JjL3JlLmps) | `93.40% <95.74%> (+0.73%)` | :arrow_up: | | [src/tokenizer.jl](https://app.codecov.io/gh/BioJulia/Automa.jl/pull/119?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BioJulia#diff-c3JjL3Rva2VuaXplci5qbA==) | `96.92% <96.72%> (+4.87%)` | :arrow_up: | | [src/stream.jl](https://app.codecov.io/gh/BioJulia/Automa.jl/pull/119?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BioJulia#diff-c3JjL3N0cmVhbS5qbA==) | `96.92% <96.92%> (ø)` | | | [src/Automa.jl](https://app.codecov.io/gh/BioJulia/Automa.jl/pull/119?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BioJulia#diff-c3JjL0F1dG9tYS5qbA==) | `100.00% <100.00%> (ø)` | | | [src/byteset.jl](https://app.codecov.io/gh/BioJulia/Automa.jl/pull/119?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BioJulia#diff-c3JjL2J5dGVzZXQuamw=) | `100.00% <100.00%> (ø)` | | | ... and [4 more](https://app.codecov.io/gh/BioJulia/Automa.jl/pull/119?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BioJulia) | |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

kescobo commented 1 year ago

FYI, it is still on my radar to kick the tires of this. I think early next month is probably realistic.

kescobo commented 1 year ago

I think early next month is probably realistic.

I was wroooong :sob:

Do you have a timeline for when you want this merged. Realistically, I need some pressure to make it a priority

jakobnissen commented 1 year ago

Haha don't I know that feeling. I also expected I would be done with this branch in the summer of 2022, so... :sweat_smile: My holidays start today, so I expect I can finish the work before the holidays are over in about 3 weeks. Maybe. No promises. Although if you want a deadline, then July 17th is probably when I'll pick this work up and finish it.

jakobnissen commented 1 year ago

Ok I'm going to merge this now and release Automa v1. @kescobo