BioJulia / Automa.jl

A julia code generator for regular expressions
Other
188 stars 15 forks source link

Backport from v1: Remove SIMD capability #124

Closed jakobnissen closed 1 year ago

jakobnissen commented 1 year ago

I've come to the conclusion that Julia does not make it possible to robustly check what CPU instructions the user has available. The current options are all undocumented, complex and brittle, and not suitable for code that cannot be accepted to break at any time

Whenever a robust way of checking for CPU instructions are available, the change is easy to revert.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 92.85% and no project coverage change.

Comparison is base (7c6a696) 89.48% compared to head (3afb922) 89.48%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## v0.8 #124 +/- ## ======================================= Coverage 89.48% 89.48% ======================================= Files 14 15 +1 Lines 1683 1645 -38 ======================================= - Hits 1506 1472 -34 + Misses 177 173 -4 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `89.48% <92.85%> (+<0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BioJulia#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files Changed](https://app.codecov.io/gh/BioJulia/Automa.jl/pull/124?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BioJulia) | Coverage Δ | | |---|---|---| | [src/Automa.jl](https://app.codecov.io/gh/BioJulia/Automa.jl/pull/124?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BioJulia#diff-c3JjL0F1dG9tYS5qbA==) | `100.00% <ø> (ø)` | | | [src/byteset.jl](https://app.codecov.io/gh/BioJulia/Automa.jl/pull/124?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BioJulia#diff-c3JjL2J5dGVzZXQuamw=) | `92.75% <92.75%> (ø)` | | | [src/codegen.jl](https://app.codecov.io/gh/BioJulia/Automa.jl/pull/124?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BioJulia#diff-c3JjL2NvZGVnZW4uamw=) | `92.02% <100.00%> (+0.43%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.