BioJulia / Automa.jl

A julia code generator for regular expressions
Other
188 stars 15 forks source link

Support 0.7 and drop 0.6 #39

Closed bicycle1885 closed 6 years ago

bicycle1885 commented 6 years ago

Close #37.

codecov-io commented 6 years ago

Codecov Report

Merging #39 into master will increase coverage by 1.02%. The diff coverage is 98.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
+ Coverage      95%   96.02%   +1.02%     
==========================================
  Files          16       16              
  Lines        1300     1032     -268     
==========================================
- Hits         1235      991     -244     
+ Misses         65       41      -24
Impacted Files Coverage Δ
src/memory.jl 100% <ø> (ø) :arrow_up:
src/codegen.jl 94.89% <100%> (+2.7%) :arrow_up:
src/sset.jl 100% <100%> (ø) :arrow_up:
src/action.jl 96% <100%> (-0.43%) :arrow_down:
src/sdict.jl 97.22% <100%> (+2.72%) :arrow_up:
src/byteset.jl 85.96% <100%> (-2.04%) :arrow_down:
src/traverser.jl 100% <100%> (ø) :arrow_up:
src/dfa.jl 100% <100%> (+0.46%) :arrow_up:
src/precond.jl 80% <100%> (-3.34%) :arrow_down:
src/re.jl 94.83% <96.42%> (+0.29%) :arrow_up:
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3c98910...a64fec1. Read the comment docs.

TransGirlCodes commented 6 years ago

This looks like it works now, can we merge and cut a release today? That way I can update the other BioJulia packages that depend on Automa to 0.7 during the JuliaCon hackathon :)

bicycle1885 commented 6 years ago

Sure. I'm going to run some benchmarks locally and then merge this change.

TransGirlCodes commented 6 years ago

Thanks! @bicycle1885, I really appreciate it! :) Wish you could be here, everyone is very nice!

bicycle1885 commented 6 years ago

Wish you could be here

Really!

Okay, the benchmarks look good. I cut a release now.

Julia 0.7 (this branch)

Case 1 ([A-z]*\r?\n)*
PCRE:                 Trial(38.700 μs)
Automa.jl:            Trial(41.111 μs)
Automa.jl (unrolled): Trial(17.430 μs)

Case 2 ([A-Za-z]*\r?\n)*
PCRE:                 Trial(39.022 μs)
Automa.jl:            Trial(50.070 μs)
Automa.jl (unrolled): Trial(30.665 μs)

Case 3 ([ACGTacgt]*\r?\n)*
PCRE:                 Trial(81.432 μs)
Automa.jl:            Trial(50.072 μs)
Automa.jl (unrolled): Trial(30.220 μs)

Case 4 ([A-Za-z\*-]*\r?\n)*
PCRE:                 Trial(81.429 μs)
Automa.jl:            Trial(62.992 μs)
Automa.jl (unrolled): Trial(33.230 μs)

Julia 0.6 (master)

Case 1 ([A-z]*\r?\n)*
PCRE:                 Trial(45.761 μs)
Automa.jl:            Trial(36.564 μs)
Automa.jl (unrolled): Trial(18.959 μs)

Case 2 ([A-Za-z]*\r?\n)*
PCRE:                 Trial(39.018 μs)
Automa.jl:            Trial(41.272 μs)
Automa.jl (unrolled): Trial(42.628 μs)

Case 3 ([ACGTacgt]*\r?\n)*
PCRE:                 Trial(81.440 μs)
Automa.jl:            Trial(49.774 μs)
Automa.jl (unrolled): Trial(42.626 μs)

Case 4 ([A-Za-z\*-]*\r?\n)*
PCRE:                 Trial(81.431 μs)
Automa.jl:            Trial(62.390 μs)
Automa.jl (unrolled): Trial(34.760 μs)
TransGirlCodes commented 6 years ago

Wish you could be here

Really!

Absolutely, I really like meeting fellow Biology julia people in real life!

Thanks for the release!