BioJulia / Bio.jl

[DEPRECATED] Bioinformatics and Computational Biology Infrastructure for Julia
http://biojulia.dev
MIT License
261 stars 65 forks source link

findfirst and haskey for IntervalCollection #472

Closed dcjones closed 7 years ago

dcjones commented 7 years ago

Adds a findfirst and haskey function to IntervalCollection that both look for exact (start, end, and strand) matches.

codecov-io commented 7 years ago

Codecov Report

Merging #472 into master will increase coverage by 0.02%. The diff coverage is 80.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #472      +/-   ##
==========================================
+ Coverage   64.72%   64.74%   +0.02%     
==========================================
  Files         166      166              
  Lines       11353    11374      +21     
==========================================
+ Hits         7348     7364      +16     
- Misses       4005     4010       +5
Impacted Files Coverage Δ
src/intervals/intervalcollection.jl 86.09% <80.95%> (-0.84%) :arrow_down:
src/intervals/interval.jl 90.66% <0%> (-1.34%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6ec0fb2...fdb7595. Read the comment docs.

dcjones commented 7 years ago

Should I be making PRs like this against GenomicFeatures.jl? I kind of lost track of what the plan is.

TransGirlCodes commented 7 years ago

@dcjones Yeah GenomicFeatures.jl and IntervalTrees.jl (if applicable). As Bio.jl is being de-monolithed, and GenomicFeatures has had it's first METADATA release :)

dcjones commented 7 years ago

Ok, cool. :+1: