BioJulia / Bio.jl

[DEPRECATED] Bioinformatics and Computational Biology Infrastructure for Julia
http://biojulia.dev
MIT License
261 stars 65 forks source link

Decompose Bio.Structure #485

Closed jgreener64 closed 7 years ago

jgreener64 commented 7 years ago

Once the BioStructures.jl package (https://github.com/BioJulia/BioStructures.jl) is tagged and released this removes the code from Bio.jl.

TransGirlCodes commented 7 years ago

This looks ok to me at first glance, but we should perhaps wait for BioStructures release, so as then the CI can actually run with the BioStructures dependency available, just to be safe.

jgreener64 commented 7 years ago

Yes agreed.

jgreener64 commented 7 years ago

So having re-triggered the build it fails because there are no tagged versions of BioStructures.jl for Julia v0.5. The first release is tagged for v0.6 minimum.

So I guess this PR should wait until Bio.jl is ready to transfer to Julia v0.6 generally?

TransGirlCodes commented 7 years ago

Well since all the old syntax actually works with 0.6 - just a few warnings here and there, we can try and just bump up the CI to 0.6, change the bare minimum syntax, and continue with the decompose :+1:

jgreener64 commented 7 years ago

Sounds good. I see you've started this process, thanks.

TransGirlCodes commented 7 years ago

Ok I've resolved the conflicts, now we can see how the tests go this time, there should be no issues.

codecov-io commented 7 years ago

Codecov Report

Merging #485 into master will decrease coverage by 33.35%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #485       +/-   ##
===========================================
- Coverage   73.04%   39.69%   -33.36%     
===========================================
  Files          16       13        -3     
  Lines        1410      519      -891     
===========================================
- Hits         1030      206      -824     
+ Misses        380      313       -67

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update ec237ab...bd3a7bd. Read the comment docs.

TransGirlCodes commented 7 years ago

Ok this can merge now, thanks for all the hard work @jgreener64, fantastic stuff!

jgreener64 commented 7 years ago

Great, thanks for the merge @Ward9250 .