search

BioJulia / BioAlignments.jl

Sequence alignment tools
MIT License
60 stars 24 forks source link

Release/v2.0.0 #41

Closed CiaranOMara closed 4 years ago

CiaranOMara commented 4 years ago

This PR contains some breaking changes but moves towards separating package responsibilities and progresses https://github.com/BioJulia/BioAlignments.jl/issues/35.

Added

Changed

Removed

cc @BenJWard, @bicycle1885

codecov[bot] commented 4 years ago

Codecov Report

Merging #41 into master will increase coverage by 3.85%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #41      +/-   ##
==========================================
+ Coverage   86.23%   90.09%   +3.85%     
==========================================
  Files          31       17      -14     
  Lines        1722      929     -793     
==========================================
- Hits         1485      837     -648     
+ Misses        237       92     -145
Impacted Files Coverage Δ
src/alignedseq.jl 96.36% <ø> (ø) :arrow_up:
src/BioAlignments.jl 100% <ø> (ø) :arrow_up:
src/pairwise/result.jl 50% <100%> (ø) :arrow_up:
src/operations.jl 88.88% <0%> (-3.71%) :arrow_down:
src/alignment.jl 83% <0%> (-1%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 09b7fd9...7cb1304. Read the comment docs.

TransGirlCodes commented 4 years ago

@CiaranOMara Are you happy for me to merge this now?

CiaranOMara commented 4 years ago

@BenJWard, if you're also happy with GenomicFeatures v2, which separates the submodules?

TransGirlCodes commented 4 years ago

Sure I'm happy. I'll look at merging them this weekend!