BioJulia / BioSequences.jl

Biological sequences for the julia language
http://biojulia.dev/BioSequences.jl
MIT License
150 stars 47 forks source link

Allow join to work with BioSymbol #234

Closed jakobnissen closed 2 years ago

jakobnissen commented 2 years ago

Allow join to work with BioSymbol

Previously, it was only possible to join BioSequences. Now, one can call join(LongRNA{2}, (RNA_U, rna"AGCA")) and have it work. Also skip unneeded calls to resize! when joining

Example use:

julia> join(LongDNA{2}, [dna"AA", DNA_G, RNA_U])
4nt DNA Sequence:
AAGT

Closes #230

Types of changes

This PR implements the following changes:

:clipboard: Additional detail

:ballot_box_with_check: Checklist

codecov[bot] commented 2 years ago

Codecov Report

Merging #234 (bbab04d) into master (fe5aabd) will increase coverage by 0.02%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #234      +/-   ##
==========================================
+ Coverage   89.26%   89.29%   +0.02%     
==========================================
  Files          31       31              
  Lines        2422     2428       +6     
==========================================
+ Hits         2162     2168       +6     
  Misses        260      260              
Flag Coverage Δ
unittests 89.29% <100.00%> (+0.02%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/biosequence/biosequence.jl 96.72% <100.00%> (+0.35%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fe5aabd...bbab04d. Read the comment docs.