BioJulia / BioSequences.jl

Biological sequences for the julia language
http://biojulia.dev/BioSequences.jl
MIT License
150 stars 47 forks source link

Reset Julia compat to v1.5 #245

Closed jakobnissen closed 2 years ago

jakobnissen commented 2 years ago

Commit 3c8f501 changed Julia compat to from 1.5 to 1.6, since the join method used sum with init keyword, which was introduced in Julia 1.6. However, BioSequences v3.0.0 was released with Julia compat 1.5. Upping Julia compat in a patch release is not allowed. Hence, the fix from commit 3c8f501 is not applied in any released version.

This commit resets Julia compat to 1.5, and rephrases the join method so it no longer uses any features not present in Julia 1.5. It has been tested with Julia v 1.5 and passes.

codecov[bot] commented 2 years ago

Codecov Report

Merging #245 (cafba3c) into master (9ec17a2) will decrease coverage by 0.04%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #245      +/-   ##
==========================================
- Coverage   88.75%   88.71%   -0.05%     
==========================================
  Files          30       30              
  Lines        2321     2321              
==========================================
- Hits         2060     2059       -1     
- Misses        261      262       +1     
Flag Coverage Δ
unittests 88.71% <100.00%> (-0.05%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/biosequence/biosequence.jl 96.77% <100.00%> (ø)
src/bit-manipulation/bitpar-compiler.jl 70.00% <0.00%> (-0.84%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9ec17a2...cafba3c. Read the comment docs.