BioJulia / BioStructures.jl

A Julia package to read, write and manipulate macromolecular structures
Other
95 stars 22 forks source link

Recipesbase compat #16

Closed mkborregaard closed 4 years ago

mkborregaard commented 4 years ago

Should be 100% safe. Might we get a release with this please? This is one of the packages holding back upgrading RecipesBase (and by extension Plots).

A clear and descriptive title (No issue numbers please)

This template is rather extensive. Fill out all that you can, if are a new contributor or you're unsure about any section, leave it unchanged and a reviewer will help you :smile:. This template is simply a tool to help everyone remember the BioJulia guidelines, if you feel anything in this template is not relevant, simply delete it.

Types of changes

This PR implements the following changes: (Please tick any or all of the following that are applicable)

:clipboard: Additional detail

:ballot_box_with_check: Checklist

codecov[bot] commented 4 years ago

Codecov Report

Merging #16 into master will not change coverage by %. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #16   +/-   ##
=======================================
  Coverage   94.89%   94.89%           
=======================================
  Files           6        6           
  Lines        1333     1333           
=======================================
  Hits         1265     1265           
  Misses         68       68           

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 65e9e4c...1402538. Read the comment docs.

jgreener64 commented 4 years ago

Thanks for fixing the bounds. Will merge and tag a release now.

jgreener64 commented 4 years ago

Release tagged.