Closed marcom closed 4 years ago
Merging #26 into master will increase coverage by
0.01%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## master #26 +/- ##
==========================================
+ Coverage 94.60% 94.61% +0.01%
==========================================
Files 6 6
Lines 1520 1524 +4
==========================================
+ Hits 1438 1442 +4
Misses 82 82
Impacted Files | Coverage Δ | |
---|---|---|
src/mmcif.jl | 98.82% <100.00%> (+<0.01%) |
:arrow_up: |
src/mmtf.jl | 99.25% <100.00%> (+0.01%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 996de9a...d11aa37. Read the comment docs.
Looks good, thanks.
Add ProteinStructure constructors from MMCIFDict and MMTFDict
This adds two new constructors
Having these functions allows one to avoid having to parse a mmCIF or MMTF file twice in the case where one wants both the dictionary and the ProteinStructure with the coordinates.
I imagine there is a small performance benefit as well as reduced disk traffic (which can be slow on a networked file system).
Not sure if adding an additional constructor is the right way to do this, but that way i didn't have to introduce new function names.
Example
Benchmark on 4v4g (a rather extreme example)