BioJulia / BioStructures.jl

A Julia package to read, write and manipulate macromolecular structures
Other
95 stars 22 forks source link

Update BioAlignments and BioSequences compat. Change LongAminoAcidSeq to LongSequence{AminoAcidAlphabet} #39

Closed kool7d closed 1 year ago

kool7d commented 1 year ago

Update BioAlignments and BioSequences compat in Project.toml. Change LongAminoAcidSeq to LongSequence{AminoAcidAlphabet}. (new type)

Types of changes

This PR implements the following changes: (Please tick any or all of the following that are applicable)

:clipboard: Additional detail

Change LongAminoAcidSeq to LongSequence{AminoAcidAlphabet}. (new type)

kool7d commented 1 year ago

Looks like a new test error unrelated to the specific changes? pdbentrylist() finds an invalid pdb id " HYD".

Edit: It must be the 3rd line. The function only skips the first 2 lines, should be 3 now I guess. Top of the file looks like this:

IDCODE, HEADER, ACCESSION DATE, COMPOUND, SOURCE, AUTHOR LIST, RESOLUTION, EXPERIMENT TYPE (IF NOT X-RAY)                           
-----------------------------------------------------------------                           
    HYDROLASE   09/16/21                    ELECTRON MICROSCOPY
100D    DNA-RNA HYBRID  12/5/1994   CRYSTAL STRUCTURE OF THE ...

It actually looks like someone made a mistake adding that to the top of the list because it makes no sense. Might not be necessary to skip that line in the future, if it gets fixed.

codecov[bot] commented 1 year ago

Codecov Report

Base: 95.41% // Head: 95.51% // Increases project coverage by +0.09% :tada:

Coverage data is based on head (cbd83b4) compared to base (453c233). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #39 +/- ## ========================================== + Coverage 95.41% 95.51% +0.09% ========================================== Files 5 5 Lines 1615 1693 +78 ========================================== + Hits 1541 1617 +76 - Misses 74 76 +2 ``` | [Impacted Files](https://codecov.io/gh/BioJulia/BioStructures.jl/pull/39?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BioJulia) | Coverage Δ | | |---|---|---| | [src/mmtf.jl](https://codecov.io/gh/BioJulia/BioStructures.jl/pull/39?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BioJulia#diff-c3JjL21tdGYuamw=) | `99.33% <100.00%> (+0.05%)` | :arrow_up: | | [src/model.jl](https://codecov.io/gh/BioJulia/BioStructures.jl/pull/39?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BioJulia#diff-c3JjL21vZGVsLmps) | `96.31% <100.00%> (+0.10%)` | :arrow_up: | | [src/pdb.jl](https://codecov.io/gh/BioJulia/BioStructures.jl/pull/39?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BioJulia#diff-c3JjL3BkYi5qbA==) | `88.61% <100.00%> (+<0.01%)` | :arrow_up: | | [src/spatial.jl](https://codecov.io/gh/BioJulia/BioStructures.jl/pull/39?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BioJulia#diff-c3JjL3NwYXRpYWwuamw=) | `95.11% <100.00%> (+0.31%)` | :arrow_up: | | [src/mmcif.jl](https://codecov.io/gh/BioJulia/BioStructures.jl/pull/39?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BioJulia#diff-c3JjL21tY2lmLmps) | `98.73% <0.00%> (-0.26%)` | :arrow_down: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BioJulia). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BioJulia)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

jgreener64 commented 1 year ago

Great, thanks for this.