Closed kool7d closed 1 year ago
Looks like a new test error unrelated to the specific changes? pdbentrylist() finds an invalid pdb id " HYD".
Edit: It must be the 3rd line. The function only skips the first 2 lines, should be 3 now I guess. Top of the file looks like this:
IDCODE, HEADER, ACCESSION DATE, COMPOUND, SOURCE, AUTHOR LIST, RESOLUTION, EXPERIMENT TYPE (IF NOT X-RAY)
-----------------------------------------------------------------
HYDROLASE 09/16/21 ELECTRON MICROSCOPY
100D DNA-RNA HYBRID 12/5/1994 CRYSTAL STRUCTURE OF THE ...
It actually looks like someone made a mistake adding that to the top of the list because it makes no sense. Might not be necessary to skip that line in the future, if it gets fixed.
Base: 95.41% // Head: 95.51% // Increases project coverage by +0.09%
:tada:
Coverage data is based on head (
cbd83b4
) compared to base (453c233
). Patch coverage: 100.00% of modified lines in pull request are covered.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Great, thanks for this.
Update BioAlignments and BioSequences compat in Project.toml. Change LongAminoAcidSeq to LongSequence{AminoAcidAlphabet}. (new type)
Types of changes
This PR implements the following changes: (Please tick any or all of the following that are applicable)
:clipboard: Additional detail
Change LongAminoAcidSeq to LongSequence{AminoAcidAlphabet}. (new type)