Closed harryscholes closed 5 years ago
Looks pretty good to me. There's one typo in the tests, and I've requested a couple of additional tests for inequality, but this is a great addition. Thanks!
Thanks for your review and great ideas, Kevin. I've added those additional tests now
Merging #10 into master will increase coverage by
0.43%
. The diff coverage is100%
.
@@ Coverage Diff @@
## master #10 +/- ##
==========================================
+ Coverage 88.32% 88.76% +0.43%
==========================================
Files 13 13
Lines 437 445 +8
==========================================
+ Hits 386 395 +9
+ Misses 51 50 -1
Impacted Files | Coverage Δ | |
---|---|---|
src/fastq/record.jl | 82.95% <100%> (+1.47%) |
:arrow_up: |
src/fasta/record.jl | 80.41% <100%> (+1.24%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update d718b47...7e835ae. Read the comment docs.
👍 Awesome! I don't seem to have merge privileges on this repo, but @BenJWard I've reviewed this and think it looks good.
Thank you for prepping this @harryscholes, and thank's for taking the time to go over it @kescobo!
Types of changes
This PR implements the following changes: (Please tick any or all of the following that are applicable)
:clipboard: Additional detail
If you have implemented new features or behaviour
Provide a description of the addition in as many details as possible. Implement
hash
and==
forFASTA.Record
andFASTQ.Record
.Provide justification of the addition.
Provide a runnable example of use of your addition. This lets reviewers and others try out the feature before it is merged or makes it's way to release.
record = FASTA.Record("id", "desc", "ACGT") record2 = FASTA.Record("id", "desc", "ACGT") record1 == record2 hash(record1) == hash(record2) unique([record1, record1, record2, record2]) == [record1] == [record2]
record = FASTQ.Record("id", "desc", "AAGCT", collect("@BCFF")) record2 = FASTQ.Record("id", "desc", "AAGCT", collect("@BCFF")) record1 == record2 hash(record1) == hash(record2) unique([record1, record1, record2, record2]) == [record1] == [record2]