Closed harryscholes closed 4 years ago
I just removed the generic method for quality
because only FASTQ
defines it.
Merging #11 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #11 +/- ##
=======================================
Coverage 88.76% 88.76%
=======================================
Files 13 13
Lines 445 445
=======================================
Hits 395 395
Misses 50 50
Impacted Files | Coverage Δ | |
---|---|---|
src/fasta/fasta.jl | 100% <ø> (ø) |
:arrow_up: |
src/fastq/fastq.jl | 100% <ø> (ø) |
:arrow_up: |
src/FASTX.jl | 100% <ø> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update fd09319...15fa8f6. Read the comment docs.
Types of changes
This PR implements the following changes: (Please tick any or all of the following that are applicable)
:clipboard: Additional detail
FASTA
andFASTQ
Export them from
FASTX
so that they are available afterusing FASTX
😄which is a bit annoying. Not massively annoying, but a bit annoying.
Also, due to lovely stuff like multiple dispatch, it feels more Julian to use generic methods that are not hidden in a namespace. This will allow cleaner code and more consistent APIs.
The same could be done for lots of other functions that are common to the
FASTA
andFASTQ
modules. I just started with these as a proof of concept. Would be keen to hear people's thoughts on this!record = FASTA.Record("abc", "def", "ACGT") identifier(record) description(record) sequence(record)
record = FASTQ.Record("abc", "def", "ACGT", collect("JJJJ")) identifier(record) description(record) sequence(record) quality(record)