BioJulia / FASTX.jl

Parse and process FASTA and FASTQ formatted files of biological sequences.
https://biojulia.dev
MIT License
61 stars 20 forks source link

Do not reach into TranscodingSteams internals #119

Closed jakobnissen closed 6 months ago

jakobnissen commented 6 months ago

When computing a FASTA index, previously, FASTX used the private state of Buffer from TranscodingStreams. However, in this case, it can just as easily be computed using a local variable.

Closes #118

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 92.61%. Comparing base (e05e5ce) to head (a0857dd). Report is 1 commits behind head on master.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #119 +/- ## ========================================== + Coverage 89.78% 92.61% +2.82% ========================================== Files 15 15 Lines 695 704 +9 ========================================== + Hits 624 652 +28 + Misses 71 52 -19 ``` | [Flag](https://app.codecov.io/gh/BioJulia/FASTX.jl/pull/119/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BioJulia) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/BioJulia/FASTX.jl/pull/119/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BioJulia) | `92.61% <100.00%> (+2.82%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=BioJulia#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.